A developer noticed that pants's shading was omitting some shaded
classes from a shaded hadoop fatjar, seemingly arbitrarily. After
much investigation, he discovered that jarjar was simply skipping
shading for all entries that followed a single misnamed class, and
the fatjar included 1.0/... entries that were being omitted.
The fix is extremely simple, just moving a single line of code.
Testing done:
Added a couple test-cases to BadPackagesTest, confirmed that they
work with this change, and break without it.
stuhood
commented
8 years ago
A developer noticed that pants's shading was omitting some shaded classes from a shaded hadoop fatjar, seemingly arbitrarily. After much investigation, he discovered that jarjar was simply skipping shading for all entries that followed a single misnamed class, and the fatjar included
1.0/...entries that were being omitted.The fix is extremely simple, just moving a single line of code.
Testing done:
Added a couple test-cases to BadPackagesTest, confirmed that they work with this change, and break without it.