Add support for literals with dash

[stremlenye]

Motivation

Shading rule rename doesn't support such patterns as "com.typesafe.akka.akka-http-core.*" or "com.typesafe.akka.akka-http-core.**". Also during substitution of String literals in such case

this.Daemonicity = this.config().getBoolean("akka.daemonic");
this.JvmExitOnFatalError = this.config().getBoolean("akka.jvm-exit-on-fatal-error");

some of them substitutes inconsistently and code starts to look like:

this.Daemonicity = this.config().getBoolean("shadeio.akka.daemonic");
this.JvmExitOnFatalError = this.config().getBoolean("akka.jvm-exit-on-fatal-error");

Solution

Add dash as a valid symbol for identifiers.

Disclaimer

I am not pretty sure in that solution (because have no experience in such low-level details) and that pull request is just conscripted to start a discussion. Please be patient and provide your comments. Thank you for your time.

[lucastorri]

Hi,

any chance this could be accepted. I'm also interested on it.

Thanks

[stuhood]

@cheister : Would you be able to review this?

EDIT: ... or I guess replace it, given the merge conflict.

[lucastorri]

Let me know if I can help (I'm not sure what is your contribution process). I can at least fix the compilation issues if needed.

Thank you.

EDIT: here is a rebased version: https://github.com/lucastorri/jarjar/tree/master

[cheister]

This is a superset of the cases fixed in https://github.com/pantsbuild/jarjar/pull/34 so we should be able to remove

if (expr.startsWith("META-INF/")) {
    expr = expr.substring("META-INF/".length(), expr.length());
}

from src/main/java/org/pantsbuild/jarjar/Wildcard.java as well.

[cheister]

Opened https://github.com/pantsbuild/jarjar/pull/35 with a rebase of this change and removal of the META-INF prefix check in Wildcard.java

[cheister]

Closing because https://github.com/pantsbuild/jarjar/pull/35 was merged