search

pantsbuild / jarjar

An export of https://code.google.com/p/jarjar/ @ svn:r142 for pants tool use and further development.
Apache License 2.0
37 stars 27 forks source link

Allow patterns to match classes under META-INF #34

Closed cheister closed 6 years ago

cheister commented 6 years ago

With Java9 you can have module classes under the META-INF directory of a jar. It will probably have unintended consequences to shade those classes in a jar but this change allows you to shade those classes.

stuhood commented 6 years ago

Is this speculative, or do you guys actually have a usecase for this? I wonder if it could have unintended consequences...

cheister commented 6 years ago

Now that I've tracked down the real issue it was a workaround for https://github.com/pantsbuild/pants/pull/5671. So I could take it or leave it?

cheister commented 6 years ago

Ok, I updated this with a better test case. I don't think you would want to map classes under META-INF but you might want to remove them from the shaded jar.