search

pantsbuild / jarjar

An export of https://code.google.com/p/jarjar/ @ svn:r142 for pants tool use and further development.
Apache License 2.0
37 stars 27 forks source link

Move jarjar build & publish over to pants. #6

Closed jsirois closed 9 years ago

jsirois commented 9 years ago

This kills the ant and maven setups as well as checked in jars and sets up the repo for maven-central publishing as well.

jsirois commented 9 years ago

Assigning to @ericzundel cc @gmalmquist

jsirois commented 9 years ago

I'd like to do the publish of Garrett's jarjar exit code fix in #5 via pants itself.

stuhood commented 9 years ago

Any reason not to just import this to pantsbuild/pants?

jsirois commented 9 years ago

Probably not - how about baby steps? I can publish Garretts fix in #5 then move.

That said - this was a good exercise in how hard is it to use pants - which we miss rolling things into pants.

jsirois commented 9 years ago

FWIW - I patch these in like so curl -L https://github.com/pantsbuild/jarjar/pull/6.patch | git am

ericzundel commented 9 years ago

Do you need to initialize pushdb to some initial version? we've already published version 1.5

ericzundel commented 9 years ago

sorry wrong button

jsirois commented 9 years ago

No - thats via --override=org.pantsbuild#jarjar=1.5.1 when I do the publish.

ericzundel commented 9 years ago

Wow, this is really awful (github pr) I agree with Stu and I think we should just pull it into pants proper too like we already did this with zinc. That leaves jmake out by its lonesome. I think we are all about to shed it anyway. But since you are ready to go with this, LGTM

jsirois commented 9 years ago

Patched in @ 8a8bfbd3c0d91231df2fae2570beb7167826c46f