search

pantsbuild / jarjar

An export of https://code.google.com/p/jarjar/ @ svn:r142 for pants tool use and further development.
Apache License 2.0
37 stars 27 forks source link

Fixup publishing to target 1.6. #7

Closed jsirois closed 9 years ago

jsirois commented 9 years ago

This also adds in jvm_options which needs to be set to a non-None list for JarPublish to function.

jsirois commented 9 years ago

@gmalmquist - assigning to you for review

jsirois commented 9 years ago

Testing done:

$ yes | ./pants clean-all publish.jar --force --local=/tmp/m2 --no-dryrun ::
$ unzip -qd /tmp/m2 /tmp/m2/org/pantsbuild/jarjar/1.5.2-SNAPSHOT/jarjar-1.5.2-SNAPSHOT.jar 
$ find /tmp/m2/ -name "*.class" | xargs file | cut -d"(" -f2 | sort | uniq -c
     57 Java 1.6)
ericzundel commented 9 years ago

LGTM

jsirois commented 9 years ago

Thanks Eric - in @ 9a7a7b3406bf79027733758d239956faf8515907