search

pantsbuild / pants

The Pants Build System
https://www.pantsbuild.org
Apache License 2.0
3.31k stars 635 forks source link

Improve @rule error messages when writing plugins #11254

Open stuhood opened 3 years ago

stuhood commented 3 years ago

After #10764, RuleGraphs are built and errors are rendered much more quickly. But even relative to before, their quality has degraded.

A ton of information is recorded during RuleGraph construction that should allow for improving the situation here. It's likely that the current strategy of "recording all eliminated options and dumping them if something is unsatisfiable at the end of the run" is the wrong approach, and that we should instead be working forward and reporting why each installed rule that might be able to satisfy a dependency was not able to.

Eric-Arellano commented 3 years ago

Duplicate of https://github.com/pantsbuild/pants/issues/10293.

Eric-Arellano commented 3 years ago

Oh, nvm, they are different things. We can close #10293.

stuhood commented 3 years ago

Relates to #11269: monomorphization is why we end up with many copies of rules.