pantsbuild / pants

The Pants Build System
https://www.pantsbuild.org
Apache License 2.0
3.25k stars 625 forks source link

Go: robustly handle ambiguous dependency inference #12761

Open tdyas opened 3 years ago

tdyas commented 3 years ago

The dependency inference rules need refactoring since there is duplication currently between the rule applied to go_package targets and the rule applied to _go_ext_mod_package targets (because _go_ext_mod_package does not have a sources field).

Ideas:

Eric-Arellano commented 2 years ago

Updated to instead focus on using ExplicitlyProvidedDependencies.maybe_warn_of_ambiguous_dependency_inference to handle ambiguous dependencies. Relates to https://github.com/pantsbuild/pants/issues/13114, which is the only time I'd realistically expect there to be ambiguous deps.