search

pantsbuild / pants

The Pants Build System
https://www.pantsbuild.org
Apache License 2.0
3.29k stars 628 forks source link

Publish jvm tools used by Pants to Maven Central #1361

Closed Yasumoto closed 9 years ago

Yasumoto commented 9 years ago

As mentioned in the review by @jsirois.

Yasumoto commented 9 years ago

Er, this may or may not be actually the right place to file this, I might have instead meant to link to https://github.com/twitter/commons/issues/348

jsirois commented 9 years ago

This is the right place. Its more involved though, 1st need to move them. Pants needs java6 compat tools, Twitter now publishes java7 classfile jars. Talked with the tweeps and they agreed on extraction of these tools from twitter/commons since they are leaf tools not used as libs at Twitter or by others.

jsirois commented 9 years ago

The https://github.com/twitter/commons/issues/348 issue is Twitter-specific and not related to this pants change. I'll "link" this issue and #1362 - where link is just some RB comment text - fwict there is no way to link issues via bugs from a different github repo.

jsirois commented 9 years ago

The jar-tool and junit-runner are now published to maven-cetnral and publishable using pants itself as part of the work closing #1411.

jsirois commented 9 years ago

And the jar-tool / junit-runner delete from commons: https://rbcommons.com/s/twitter/r/2187/ https://github.com/twitter/commons/pull/375

jsirois commented 9 years ago

The java-compiler is now published to maven-central

jsirois commented 9 years ago

And the java-compiler delete from commons https://rbcommons.com/s/twitter/r/2196/ https://github.com/twitter/commons/issues/376

jsirois commented 9 years ago

The last remaining tools - the ExplicitSpecsRunnerMain and DependencyEmitter scala plugin - are being killed and no longer used by pants, see:

As such this publishing work is complete.