search

pantsbuild / pants

The Pants Build System
https://www.pantsbuild.org
Apache License 2.0
3.33k stars 636 forks source link

Support generation of ConnectRPC Go code #20684

Open johansja opened 7 months ago

johansja commented 7 months ago

Currently using ConnectRPC over gRPC for our RPC communication. It would be better if protobuf_source(s) target also support connect as an option in addition to grpc currently.

We are now using buf tool to generate and perform various checking. buf lint and buf fmt are already integrated with pants. We are also using buf generate today to generate these ConnectRPC related Go code.

ndellosa95 commented 3 months ago

Currently using ConnectRPC over gRPC for our RPC communication. It would be better if protobuf_source(s) target also support connect as an option in addition to grpc currently.

We are now using buf tool to generate and perform various checking. buf lint and buf fmt are already integrated with pants. We are also using buf generate today to generate these ConnectRPC related Go code.

Hey @johansja, I think I need this as well and was about to pick this up, but do you have any more details about what you're looking for on your end?

johansja commented 3 months ago

Hi @ndellosa95 , currently I have moved on from Pants to Bazel due to some Go issues. But generally I still think Pants is better in term of developer experience. I was hoping for Pants to be able to just generate ConnectRPC related codes for both Go and Python to replace but generate

ndellosa95 commented 3 months ago

Hi @ndellosa95 , currently I have moved on from Pants to Bazel due to some Go issues. But generally I still think Pants is better in term of developer experience. I was hoping for Pants to be able to just generate ConnectRPC related codes for both Go and Python to replace but generate

Cool so basically you just wanted to use buf generate as a code generator?