search

pantsbuild / pants

The Pants Build System
https://www.pantsbuild.org
Apache License 2.0
3.19k stars 613 forks source link

Update release docs to work around file watcher race condition. #21081

Closed benjyw closed 2 weeks ago

benjyw commented 2 weeks ago

The start_release.py script modifies workspace files, and so will race with the file watcher to complete before being killed and restarted. And since the process is not idempotent (e.g., it creates a local git branch) that restarted process can fail.

benjyw commented 2 weeks ago

The process indeed isn't (I debug-printed the value of restartable which was False as expected), but apparently the entire @goal_rule will kill-and-restart (again, verified by debug prints) regardless, which makes restartable misleading I guess?