search

pantsbuild / pants

The Pants Build System
https://www.pantsbuild.org
Apache License 2.0
3.33k stars 638 forks source link

Switch to using the native options parser values #21385

Closed benjyw closed 2 months ago

benjyw commented 2 months ago

But still compare against the legacy parser so we can warn about discrepancies.

benjyw commented 2 months ago

This is going to take another day or so, as I figure out one thing that the tests uncovered, namely that we still rely on the legacy parser to detect unconsumed cmd-line flags. Will have a little think on how best to address this, probably in another PR.

huonw commented 2 months ago

No worries. Is there a chance we could keep the 2.23 releases moving forward by either:

(My thinking here is that we're a bit stuck in a spiral of long releases because delays lead to bigger releases lead to more things that can go wrong lead to delays 😄 )

cognifloyd commented 2 months ago

I think delaying the switch to 2.24 makes the most sense. Cherry-picking back to 2.23 is fine if the issues can be resolved quickly.

benjyw commented 2 months ago

I don't want to delay, but we can cherry-pick.

huonw commented 2 months ago

Okay, I'll merge #21383 to start that rolling

benjyw commented 2 months ago

OK, tracking arg consumption is implemented here: https://github.com/pantsbuild/pants/pull/21410

benjyw commented 2 months ago

This is ready for another look, thanks!

benjyw commented 2 months ago

@huonw thanks for expressing your discomfort, which I acknowledge. I can wait to 2.24.x if you are more comfortable with that (and it sounds like @cognifloyd prefers that too). For now I will merge (once tests pass) without the auto-cherrypick, so we have a chance to discuss further.