search

pantsbuild / pants

The Pants Build System
https://www.pantsbuild.org
Apache License 2.0
3.33k stars 638 forks source link

pass along query parameters to s3:// urls #21392

Closed cburroughs closed 2 months ago

cburroughs commented 2 months ago

The brings s3:// protocal urls to party with handling of https:// ones. The intent is to be able to pass along versionId or other S3 parameters along the lines of:

file(
    name="s3_source_test",
    source=http_source(
        url="s3://test-data/users/csb/foo.txt?versionId=1Pz.idoTGIoFJ6l8UB1aGV08QUmoj9gD"
        sha256="fe132f9f52c25bed628cb86ed2859ce73d7b366f4eb5eee6c5b09981565368d6",
        len=7,
    ),
)
tdyas commented 2 months ago

Maybe update src/python/pants/backend/url_handlers/s3/integration_test.py with a test?