actions/upload-artifacts@v3 is being removed (5 Dec 2024), affects Linux build-wheels jobs

[huonw]

Describe the bug

According to https://github.blog/changelog/2024-11-05-notice-of-breaking-changes-for-github-actions/#artifacts-v3-brownouts, the actions/upload-artifacts@v3 behaviour is being deprecated and removed. Timeline:

• brown-out: November 14, 9am – 10am EST
• brown-out: November 21, 9am – 5pm EST
• removal: December 5

This affects the Linux build-wheels jobs which run in a container, and require node16 compatibility (only available in v3, not v4, of this action).

https://github.com/pantsbuild/pants/blob/9244fcc8530ac93fcc7a8e0d1fdcbabe61090f36/src/python/pants_release/generate_github_workflows.py#L902

We'll need to remove the usage of this from all active branches, or CI will fail.

Options:

1. quick-hack: stop uploading the logs at all
2. better: use the container only for the build, either by running the whole pants invocation in it, or using a docker environment within pants
3. ???

Pants version N/A

OS N/A

Additional info Related discussion happened in: https://github.com/pantsbuild/pants/pull/21133

[tdyas]

Can we just upgrade to v4 of actions/upload-artifact?

[huonw]

I think that requires node20 which isn't compatible with the container used (see #21133 and #21172), although feel free to dig into the git history and/or experiment more!