search

pantsbuild / scie-pants

Protects your Pants from the elements.
https://www.pantsbuild.org/docs/installation
Apache License 2.0
18 stars 17 forks source link

`Unknown flag --python-repos-repos on global scope` with older Pants versions #321

Open thejcannon opened 7 months ago

thejcannon commented 7 months ago 
josh@cephandrius:~/work/splash$ cd $(mktemp -d)
josh@cephandrius:/tmp/tmp.MoI8b5oKpj$ touch pants.toml
josh@cephandrius:/tmp/tmp.MoI8b5oKpj$ touch BUILDROOT
josh@cephandrius:/tmp/tmp.MoI8b5oKpj$ PANTS_VERSION=2.0.2 pants --no-verify-config help-all
Unknown flag --python-repos-repos on global scope
Use `pants help` to get help.
10:38:18.20 [ERROR] Unknown flags --python-repos-repos on global scope

(Use --print-stacktrace to see more error details.)

Will test to see what version is "fixed"

thejcannon commented 7 months ago

Oddly... https://www.pantsbuild.org/v2.0/docs/reference-python-repos

So it might be some kind of options-parsing issue?

thejcannon commented 7 months ago

2.8.0 works, 2.7.2 doesn't

thejcannon commented 7 months ago

This may be moot, as we're soon going to remove PANTS_SHA support (likely in tandem with the 2.18 Pants release).

kaos commented 4 months ago

This may be moot, as we're soon going to remove PANTS_SHA support (likely in tandem with the 2.18 Pants release).

How is this related to the PANTS_SHA support?

thejcannon commented 4 months ago

Yeah, I don't remember...

kaos commented 4 months ago

why are there so limited emoji reactions.. I wanted a 😢 one..

huonw commented 4 months ago

I suspect the discussion may've moved on with the changes in https://github.com/pantsbuild/scie-pants/pull/351, but the code that adds this argument explicitly calls out PANTS_SHA: https://github.com/pantsbuild/scie-pants/blob/8dc8d4159fc5a5b30cf9ece2c0a3d866b6524022/tools/src/scie_pants/pants_version.py#L37-L51