search

panuhorsmalahti / gulp-tslint

TypeScript linter plugin for Gulp
MIT License
118 stars 44 forks source link

Drop dependency on deprecated `gulp-util` #140

Closed demurgos closed 6 years ago

demurgos commented 6 years ago

Hi, gulp-util is deprecated. It should be replaced by dependencies on the individual components used by gulp-eslint. The README lists alternatives for the different components.

See https://github.com/gulpjs/gulp/issues/2065

panuhorsmalahti commented 6 years ago

Should be straightforward to replace:

demurgos commented 6 years ago

Hi, I confirm that this is straightforward replacement (except that gutil.colors is better replaced with chalk). The main blocker is the lack of type definitions for plugin-error. I opened a PR to fix this. I have a patched version of gulp-tslint ready to be submitted but it uses my temporary fork of plugin-error until the types are available. I'll submit it is as soon as the types are ready.

demurgos commented 6 years ago

The types for plugin-error got merged, they should be published soon.

demurgos commented 6 years ago

plugin-error@1.0.0 has been published, it bundles its types.

Silic0nS0ldier commented 6 years ago

ansi-colors being suggested is likely down to Gulp using it. If features unique to chalk aren't being used, may as well use ansi-colors. @types/ansi-colors has got the library covered by the way. I'll see if I can get typings in it directly too since I'm probably going to be using it in my own projects.

demurgos commented 6 years ago

@Silic0nS0ldier Feel free to open a new PR. Having a smaller dependency would be a good thing.

I'm closing this issue since the updated version is now on npm.