panuhorsmalahti / gulp-tslint

TypeScript linter plugin for Gulp
MIT License
118 stars 44 forks source link

Old version of tslint used #18

Closed tomitrescak closed 9 years ago

tomitrescak commented 9 years ago

Hi

Thanks for the plugin! I have a bit of a problem that you do not provide for use of latest language enhancements such as "for of" loop and linting fails. Tslint already supports that, or at least it is not throwing errors. Seems like you are using outdated ts lint?

Following is ok for tslint, but fails with gulp-tslint with use of undeclared variable and duplicate variable

var fixtures : string[] = ["siteConfig"];
for (var fixture of fixtures) {
}

Thanks!

panuhorsmalahti commented 9 years ago

Hmm, gulp-tslint uses the latest version of tslint. What version of gulp-tslint are you using?

panuhorsmalahti commented 9 years ago

I added a test case which doesn't report any errors for me: https://github.com/panuhorsmalahti/gulp-tslint/commit/e2bc2d570c1420b19f8796cc6fbc95cc59c51c46 Can you try installing gulp-tslint 3.0.1-beta to an empty folder with npm install gulp-tslint@3.0.1, then cd testand gulp forof and paste the output?

tomitrescak commented 9 years ago

That's weird. I did update on gulp tslint and it did have older version of tslint so I had to manually replace it in node modules. On Fri, 29 May 2015 at 05:23 Panu Horsmalahti notifications@github.com wrote:

I added a test case which doesn't report any errors for me: e2bc2d5 https://github.com/panuhorsmalahti/gulp-tslint/commit/e2bc2d570c1420b19f8796cc6fbc95cc59c51c46 Can you try installing gulp-tslint@3.0.1-beta to an empty folder with npm install gulp-tslint@3.0.1, then cd testand gulp forof and paste the output?

Reply to this email directly or view it on GitHub https://github.com/panuhorsmalahti/gulp-tslint/issues/18#issuecomment-106571659 .

tomitrescak commented 9 years ago

Ok, manually removing gulp-tslint from the project and from ~/.npm and reinstalling it solved the issue. The weird part is that npm update did nothing. Thanks for your help.