panuhorsmalahti / gulp-tslint

TypeScript linter plugin for Gulp
MIT License
118 stars 44 forks source link

Option summarizeFailureOutput: true does not work with emitError: false #41

Closed tkrotoff closed 8 years ago

tkrotoff commented 8 years ago

They should be independent.

Example:

gulp.task('tslint', () =>
    ...
    .pipe(tslint.report('prose', {emitError: false, summarizeFailureOutput: true}))
);
$ gulp tslint
...
[22:29:42] [gulp-tslint] error app.ts[24, 71]: missing whitespace
[22:29:43] Finished 'tslint' after 865 ms

vs

gulp.task('tslint', () =>
    ...
    .pipe(tslint.report('prose', {emitError: true, summarizeFailureOutput: true}))
);
$ gulp tslint
...
[22:29:01] [gulp-tslint] error app.ts[24, 71]: missing whitespace
[22:29:01] 'tslint' errored after 851 ms
[22:29:01] Error in plugin 'gulp-tslint'
Message:
    Failed to lint: 1 errors.

Would be nice to have the message Failed to lint: x errors even if emitError is false. In my case it helps me to see if the number of errors increases (knowing that I have already n errors that are false positive).

panuhorsmalahti commented 8 years ago

Fixed in 4.1.0.

tkrotoff commented 8 years ago

Cool! Thx