search

panuhorsmalahti / gulp-tslint

TypeScript linter plugin for Gulp
MIT License
118 stars 44 forks source link

rulesDirectory option of tslint.json not handled correctly #55

Closed jkillian closed 8 years ago

jkillian commented 8 years ago

gulp-tslint version: 4.3.3 tslint version: 3.5.0 Operating system: All

If a tslint.json file specifies a rulesDirectory property, gulp-tslint needs to resolve those paths relative to the location of the tslint.json file and provide those to TSLint via the rulesDirectory option found here. TSLint has no way of resolving these paths itself since it has no way of knowing where the tslint.json file was located.

This is a subtle bug and I understand that it's not super predictable behavior from TSLint, but I'm now sure what TSLint could do differently. tslint-loader also has a similar bug.

valorkin commented 8 years ago

will be fixed by #63 when merged

panuhorsmalahti commented 8 years ago

Hopefully somebody tests that this actually works.

valorkin commented 8 years ago

I am actually using it :) https://github.com/valor-software/ng2-bootstrap see package.json

On Sun, Apr 24, 2016, 18:55 Panu Horsmalahti notifications@github.com wrote:

Hopefully somebody tests that this actually works.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/panuhorsmalahti/gulp-tslint/issues/55#issuecomment-213987921