panva / openid-client

OAuth 2 / OpenID Connect Client API for JavaScript Runtimes

MIT License

1.83k stars 392 forks source link

fix: increase http timeout to 10s #164

Closed sami-sweng closed 5 years ago

sami-sweng commented 5 years ago

Hi @panva,

Thank you for your quick reactions and fix yesterday!

So as I told you, I was making the PR because of a server that randomly timedout when calling it's key route. So here is the PR that we will use in prod to make 100% sure that this scenario is not happening. Since we have a working cache now it should almost never be used, but better safe than sorry.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@571d901). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             master   #164   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     18           
  Lines             ?    808           
  Branches          ?      0           
=======================================
  Hits              ?    808           
  Misses            ?      0           
  Partials          ?      0

panva commented 5 years ago

You can customize the timeout and other common http request properties in your own code base.