panva / openid-client

OAuth 2 / OpenID Connect Client API for JavaScript Runtimes
MIT License
1.83k stars 392 forks source link

code_challenge_method is not send with the authorize request #322

Closed borleth closed 3 years ago

borleth commented 3 years ago

Describe the bug

In order to test PKCE on our IDP, we see the code_challenge_method is not send during the first authorize endpoint. So in reference to the RFC, the IDP need understand it's "plain" challenge, the default value.

To Reproduce Issuer and Client configuration: (inline or gist) - Don't forget to redact your secrets.

// Issuer configuration (issuer.metadata) and how it is constructed (discovery or manual?)
{
  // ...
}
// Client configuration (client.metadata) and how it is constructed (fromUri or manual?)
{
  // ...
}

Steps to reproduce the behaviour:

Expected behaviour A clear and concise description of what you expected to happen.

Environment:

Additional context Add any other context about the problem here.

panva commented 3 years ago

Hi. I'm closing this issue because it does not follow the template and provides no details as to how you're using the module, not even a understandable description.