Closed frcouceiro closed 2 years ago
The client is exhibiting correct behaviour, 200 OK is the expected response. PR not needed. The provider, from looking at the code, the tests, and even testing my deployment, returns a 200 OK, not 204. PR not needed.
➜ curl -iX POST https://op.panva.cz/token/revocation -d 'client_id=bu7K-J98Ccwmca2-RcXT9&token=foo'
HTTP/2 200
date: Fri, 08 Apr 2022 15:01:35 GMT
content-length: 0
Maybe there's something at play in your deployment of the provider, I don't know.
Please create and share a minimal reproduction code for the provider application that i can easilly run and reproduce locally if you'd like me to look into it, as-is, I cannot reproduce the reported provider behaviour.
Thank you for the quick response.
Naturally you are right. I can now see provider response being a 200 OK, somehow when debugging openid-client code response object I do always get a 204. I am using serverless-offline + serverless-http plugin and I am starting to think it may be related. Will test by using express server directly. If I end up with the same issue I will submit a minimal reproducible project so we can further look into it. Cheers
Describe the bug I am testing both the client and node-oidc-provider and when issuing a revoke request I get the following error:
Turns out the provider is responding with status 204 as opposed to what the client expects (status 200). I guess I have two alternatives:
To Reproduce Issuer and Client configuration: (inline or gist) - Don't forget to redact your secrets.
Steps to reproduce the behaviour:
Expected behaviour
I tested option 2. above and it does work however as I am just starting to get my hands on both projects and I am not sure these are the only possibilities or even if they adhere to these projects principles. I was hoping to get an answer on that and I can submit a PR with option 2. if you see fit 👍
Thank you for the great work!
Environment:
Additional context Add any other context about the problem here.