panva / openid-client

OAuth 2 / OpenID Connect Client API for JavaScript Runtimes
MIT License
1.83k stars 392 forks source link

fix(passport): ignore static state and nonce passed to Strategy() #556

Closed prust closed 1 year ago

prust commented 1 year ago

@panva: As discussed, this pull request ignores static state and nonce values that are passed to the Strategy() (a mis-use of the API). Ignoring them here allows them to be dynamically generated on each authenticate() for flows that require them.

I also documented how to pass dynamic parameters to authenticate() (in a separate commit, daa70a5, in case you aren't interested in this change).

Note that this is a breaking change for users who are mis-using the API in this way if their Authorization Server requires a nonce or state for a flow where the spec does not require it.

Let me know if tests or anything else would be helpful.