Allow `default_max_age` to be optional

panva / openid-client

OAuth 2 / OpenID Connect Client API for JavaScript Runtimes

MIT License

1.83k stars 392 forks source link

Allow `default_max_age` to be optional #583

Closed bestickley closed 1 year ago

bestickley commented 1 year ago

The docs say that default_max_age is an optional Client constructor property. However, it is used as if it is a required field. Currently this.default_max_age fails if default_max_age property is not set so this allows it to not be set.

bestickley commented 1 year ago

Alternatively, the TS types could be updated to make this property required in the Issuer constructor

panva commented 1 year ago

Currently this.default_max_age fails

How?

this allows it to not be set.

This PR actually doesn't change anything, other than break compatibility with the supported nodejs versions.

bestickley commented 1 year ago

sorry, @panva. I was misinterpreting the error message I was seeing when I suggested this change. Appreciate your discernment and maintaining this awesome library!