search

panva / paseto

PASETO (Platform-Agnostic SEcurity TOkens) for Node.js with no dependencies
MIT License
428 stars 26 forks source link

Resolve issue with wont parse Uint8Array #13

Closed jiafengwu0301 closed 3 years ago

jiafengwu0301 commented 3 years ago

When I run my Jest test, it passes a Uint8Array

On Tue, Aug 25, 2020 at 10:04 AM Filip Skokan notifications@github.com wrote:

@panva requested changes on this pull request.

I don't understand when this change actually kicks in. Can you elaborate? Using the exposed API, when is payload actually passed in as Uint8Array?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/panva/paseto/pull/13#pullrequestreview-474630607, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPNRVIXGM3ABURTKWV4OWDSCPOHLANCNFSM4QJ7JHHQ .

panva commented 3 years ago

When I run my Jest test, it passes a Uint8Array

What environment?

panva commented 3 years ago

It would be helpful if you provided a failing test that uses the public API.

jiafengwu0301 commented 3 years ago

node 14, jest 24.9.0

On Tue, Aug 25, 2020 at 10:10 AM Filip Skokan notifications@github.com wrote:

When I run my Jest test, it passes a Uint8Array

What environment?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/panva/paseto/pull/13#issuecomment-680121971, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPNRVMLI2UV54GEB5XTSKTSCPO65ANCNFSM4QJ7JHHQ .

panva commented 3 years ago

I'm not going to accept this PR without seeing a failing test in the project's test suite, one that uses the public API from the documentation.

What I get from this conversation so far is that you're probably transpiling this module in which case I will not accommodate such use.

Note that Node.js 14 is in the CI matrix and everything's passing there.