Closed kschaefe closed 1 year ago
What's 'PropertyKey'? Given it can only be a parsed JSON object the only key types would be strings.
I used PropertyKey
, which is string | number | symbol
for the inputs, but made the outputs use string
. I didn't want to accidentally cause someone's code to fail to compile on input, so was being cautious there. I'm happy to use string
as the key type for both inputs and outputs if that's what you'd like.
I used
PropertyKey
, which isstring | number | symbol
for the inputs, but made the outputs usestring
. I didn't want to accidentally cause someone's code to fail to compile on input, so was being cautious there. I'm happy to usestring
as the key type for both inputs and outputs if that's what you'd like.
Makes sense. Thanks for the explanation.
Please add - run: npm run test-types
at the end of .github/workflows/test.yml
Solves #35.