adds language support with I18n translations

panvol / pandemic-volunteers

❤️ Pandemic Volunteers | ⚠️ Help Wanted

https://pandemicvolunteers.org

MIT License

29 stars 7 forks source link

adds language support with I18n translations #36

Closed dimanyc closed 4 years ago

dimanyc commented 4 years ago

Closes #4

replaces a bunch of hard coded text nodes with I18n internationalizations. Adds view specs to ensure these internationalizations are rendering correctly

dimanyc commented 4 years ago

I replaced all the repeating blobs with partials in https://github.com/panvol/pandemic-volunteers/pull/36/commits/84b24cea9e3aab8348fcb92bc85e66a78e129b29 because it was taking a long time to figure out where each translation node goes. Let me know if you want this reverted back to static erb/html

hantuzun commented 4 years ago

Thank you @dimanyc! I've worked on another branch and created a PR for it since your work is on a fork of yours.

See: https://github.com/panvol/pandemic-volunteers/pull/40