search

panzarino / mlbgame

A Python API to retrieve and read MLB GameDay data
http://panz.io/mlbgame/
MIT License
526 stars 112 forks source link

Venue #13

Closed rationalpastime closed 7 years ago

rationalpastime commented 8 years ago

Any chance that future updates will parse the venue value from linescore.xml?

Of course, 99% of the time, the venue is just the home team's park, but having venue data would help sort out games like last Sunday's Marlins-Braves contest at Fort Bragg, and the occasional overseas/Puerto Rico contests.

In my case, I use (your excellent) mlbgame in a workflow that includes park adjustments for player stats and home field adjustments for win expectancies. Being able to capture the venue would help ensure that I'm not correcting for park or home field factors that don't apply.

panzarino commented 8 years ago

First, that's awesome that you are using this API in a workflow! I will work on parsing the linescore.xml (which has venue) and will send out a release sometime within a week or two.

panzarino commented 7 years ago

Just checked out www.rationalpastime.com, it looks really awesome! I will be consistently checking it throughout the season. Great use of the API!

rationalpastime commented 7 years ago

Much appreciated. I was planning on using the package for some time, but when my kid was born and I no longer had time to manually input the data into excel every morning, I decided I had to buckle down and go all Python on that bad boy.

On Thursday, July 7, 2016, Zach Panzarino notifications@github.com wrote:

Just checked out www.rationalpastime.com, it looks really awesome! I will be consistently checking it throughout the season. Great use of the API!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zachpanz88/mlbgame/issues/13#issuecomment-231259817, or mute the thread https://github.com/notifications/unsubscribe/ASZyT7ufgKGXNGniBnvJLIhQFzKpK0Dfks5qTbP5gaJpZM4JHaiS .

panzarino commented 7 years ago

I have finished implementing this feature in e863b95d309d3b36c19fad3db52875cd5eae297d. I will release a new version later today/tonight (2.2) (I have to do some doc updates).

panzarino commented 7 years ago

Just released the new version, feel free to update. The new overview function is what you will be looking for. Hopefully it works for what you need.

rationalpastime commented 7 years ago

Awesome. Thank you for this.

On Tue, Jul 19, 2016 at 2:07 PM, Zach Panzarino notifications@github.com wrote:

Just released the new version, feel free to update. The new overview function is what you will be looking for. Hopefully it works for what you need.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zachpanz88/mlbgame/issues/13#issuecomment-233717247, or mute the thread https://github.com/notifications/unsubscribe-auth/ASZyTyGJvmb5Npu4fBuZ_S7TderY8Wm2ks5qXRJigaJpZM4JHaiS .