G+ stopped working ?!?

[thedod]

This is what I'm getting (on firefox):

Load denied by X-Frame-Options: https://accounts.google.com/ServiceLogin?... does not permit framing.

Maybe they've changed their API or something?

[panzi]

I'll have a look at it later (after my work day).

[panzi]

I can't reproduce any problems. It works for me. Do you have a demo of the bug? What exactly happens for you? Maybe it was a temporal issue on Googles side?

[thedod]

Attaching a screenshot. To reproduce:

• On firefox, be logged in to a gmail account that has g+
• Go to https://sidelang.com/ssp/demo/testbuild.html
• First click on g+ works fine (brings the real widget)
• Second click shows a popup that disappears as soon as it loads
• Another try, button gets an "error" icon, and there's an error on the console

(on chrome it fails in a different way).

[panzi]

It works for me with Firefox 23.0.1 and Chrome 27.0.1453.110 on x86_64 Linux. Are you sure you don't have some kind of popup blocker installed that loads popups in the iframes which initiate them? Because for me the login page loads in a popup. For you it seems to load in the tiny iframe of the G+ button. You wouldn't be able to login with such a tiny fraction of the login form anyway. The login page is of course prevented from ever loading in an iframe in order to prevent invisible iframe injection attacks.

[thedod]

It works for me with Firefox 23.0.1 and Chrome 27.0.1453.110 on x86_64 Linux.

I tried with firefox 24.0 and chromium 28.0.1500.71. Still, on a friend's chromium 28.0.1500.71 this seems to work

Are you sure you don't have some kind of popup blocker installed that loads popups in the iframes which initiate them?

I've disabled adblock-plus and sharemenot. AFAIK there's nothing else, but I'll keep checking what's the diff.

Because for me the login page loads in a popup.

The login popup was never a problem. When I'm logged in to gmail as an account without g+, I get a "join g+" popup.

(It's just that I don't want to join :wink:).

When I'm logged in as a user with g+, first time there's that popup that disappears right away (probably just checks that I'm logged in), then - on the next click - there's the problem I've reported. BTW, on my friend's PC (where it works), it's the same: 2nd click pops up something that disappears right away, and 3rd click seems to work.

For you it seems to load in the tiny iframe of the G+ button. You wouldn't be able to login with such a tiny fraction of the login form anyway. The login page is of course prevented from ever loading in an iframe in order to prevent invisible iframe injection attacks.

As far as I understand, the login page (if needed) appears in a popup (and doesn't get blocked - at least if I disable adblock plus and sharemenot). The problem happens when I'm already logged in.

Anyway - now that I have access to at least one browser where this works - I'll try to figure out what's the difference between it and my own browsers.

[panzi]

Anyway - now that I have access to at least one browser where this works - I'll try to figure out what's the difference between it and my own browsers.

Yes that would be great. Could you try to figure out where the error message on the console is coming from? If it is an iframe, which one is it? It's the login page, which shouldn't be loaded in an iframe. Anyway, all I do is calling the G+ script, so I doubt the bug is in Social Share Privacy.

[panzi]

Any news on this? Does it work for you now or did you find the problem?

[thedod]

Sorry. I'm swamped with work at the moment, so there are no news: g+ still doesn't work (at least on the few machines/browsers we have here in the wilderness) and I can't figure out why. Anyway, this was reported by the Sharefest crew, so maybe they could help here. I believe they're much better than me at browser-side debugging.

[panzi]

I see. Does the original embed code from Google work?

[thedod]

I'll try to check and let you know. Hopefully today.