search

panzi / SocialSharePrivacy

Fork of "jquery.socialshareprivacy.js | 2 Klicks fuer mehr Datenschutz" http://www.heise.de/extras/socialshareprivacy/ that is extensible.
http://panzi.github.com/SocialSharePrivacy/
677 stars 81 forks source link

line-mode layout issues #33

Open ThomasWaldmann opened 11 years ago

ThomasWaldmann commented 11 years ago

There are some layout issues in line mode:

If all buttons take more width than available, it wraps to another line, but usually the lines do not have enough vertical distance. I worked around that by specifying more height.

Another issue is that it in general tends to look rather ugly as the spacing is not the same for every button, e.g. the visual distance between switch and service button but also the visual distance between service button and the switch of the element right of that (this is maybe due to some buttons getting wider when activated).

And even if one tries to work around that by setting some specific common width (as in the screenshot), it still looks strange, because there is more white space on the right of the whole share block than on the left.

ssp-line

panzi commented 11 years ago

Yeah, if you want to improve the CSS, I accept patches/pull requests. ;)

ThomasWaldmann commented 11 years ago

That's me and CSS: http://i.imgur.com/Q3cUg29.gif

panzi commented 11 years ago

Yeah, that seems accurate.

Well, if anyone sends me a patch about that I'll merge it. But it's not a big enough itch for me. Especially because it very much depends on how you use it. You might want to optimize for different things depending on how you embed it in your page (different widths/heights; making buttons the same width makes only sense if you have >1 line, otherwise there will be awkward white spaces).