paolobenve / myphotoshare

MOVED TO GITLAB! --- A Web 2.0 Photo Gallery Done Right via Static JSON, Dynamic Javascript and a bit of php for sharing
15 stars 0 forks source link

Issue #65: Video don't play with FireFox. Don't change media when it's not a photo. #69

Closed pmetras closed 6 years ago

pmetras commented 6 years ago

Solves issue #65.

Tested with FireFox and Chromium. One of the reasons why it's more visible on FireFox is that you can start a video when you click on the player image, while on Chromium you have to use the play button in the control bar. Probably could be a bit nicer by changing the mouse icon when over the HTML5 player, but at least it works correctly.

paolobenve commented 6 years ago

but this way changing the media would require clicking on the side arrows, wouldn't it?

pmetras commented 6 years ago

Yes, but only for the videos. Usually, clicking on a video in a video player starts the video. This behavior is more natural for users than holding [Shift] or [Control] when you click on it. And like I said, on FireFox, the player displays the big triangle (l>) on the still image inviting the user can click on it.