paolobenve / myphotoshare

MOVED TO GITLAB! --- A Web 2.0 Photo Gallery Done Right via Static JSON, Dynamic Javascript and a bit of php for sharing
15 stars 0 forks source link

Pylint #81

Closed pmetras closed 6 years ago

pmetras commented 6 years ago

Linted the scanner code with Pylint and corrected most obvious errors and warning.

As I started using VS Code, I wanted to test the pylint option that starts pylint when a file is saved. It output many "problems" in the code and I decided to clean the simplest ones. I thought it would be simple but I had sometimes to change large pieces of code and was not as simple as thought. In the end, that's quite a large pull request...

Here is the summary of the changes:

Now remain big pieces of code, particularly large methods that must be broken in smaller ones. Also I want to hide protected methods. When I have time, I'll try adding docstring to modules and functions.

paolobenve commented 6 years ago

good work!!! the code I wrote myself was quite approximative...

paolobenve commented 6 years ago

merged to master too, let's keep making all this stuff better in master