search

paoloboni / binance-scala-client

A functional Scala client for Binance
MIT License
40 stars 16 forks source link

Spot Margin API requests are absent #334

Open kudr2001 opened 1 year ago

kudr2001 commented 1 year ago

Hi! Actually it's not an issue but a feature request. There's a margin section in Spot API ("/sapi/v1/margin/") which is not implemented in binance-scala-client yet. Awesome client! New order. Is there a plan to implement this section in near future? At least Open/Close/List orders.

paoloboni commented 1 year ago

Hi @kudr2001, apologies for the late reply. Sure that would be possible. Would you feel comfortable at working on a PR for it? I'm happy to help in any case

kudr2001 commented 1 year ago

Hi @paoloboni, NP. Ok, I'll make a PR this week.

paoloboni commented 1 year ago

Hi @kudr2001 , I thought this was an additional endpoint under Spot API, but I realised only later it's a separate API (sapi), in which case there's some overhead to make some space for the new API group and I'm happy to pick this up.

I pushed some (wip) changes now to this branch: https://github.com/paoloboni/binance-scala-client/tree/sapi-new-order

The main problem I see with this API is that there's no test network available, so it won't be possible to write end-to-end tests similarly to what was done for the existing APIs.