search

paolochiodi / htmlcompressor

A work in progress port of google's htmlcompressor.jar
Other
152 stars 26 forks source link

Empty text area's are disappearing #3

Closed karlfreeman closed 11 years ago

karlfreeman commented 11 years ago

Is this the desired behaviour?

paolochiodi commented 11 years ago

Hi, thank you for pointing this out. If it's ok to you I'd close this pull request and will push failing test and solution in the same commit by my side.

paolochiodi commented 11 years ago

The problem should be solved now. I've also bumped the version and updated the gem on rubygems.

Please let me know if now everything is ok for you.

karlfreeman commented 11 years ago

No problem with your commit over mine, didn't know if a 'preserve' test or general one would be more appropriate. Thanks for the speedy fix.

paolochiodi commented 11 years ago

Thank you for bringing me back to htmlcompressor. It definitely deserves more attention :)

karlfreeman commented 11 years ago

For sure, particularly the rack side as I don't think many people are aware of it because its not a rack-* style gem.

paolochiodi commented 11 years ago

would you suggest to change the name or to split the gem?

karlfreeman commented 11 years ago

Doing a quick search there are things like html_press which is dead. Plus rack-html-compress on rubygems is free. I'd put money on more people using the rack middleware if it had a rack-* name.

Looking through the rack implementation, a split with a heavy version dependency I think would work well :).

Let me know your thoughts.

karlfreeman commented 11 years ago

Would be happy to help out as we're using it here