paolodellepiane / vscode-fantomas-fmt

MIT License
17 stars 4 forks source link

Adjust default settings to F# code formatting guidelines #7

Closed alfonsogarciacaro closed 5 years ago

alfonsogarciacaro commented 5 years ago

Three of the default settings doesn't seem to match the F# code formatting guidelines. Maybe they should be changed?

alfonsogarciacaro commented 5 years ago

Related: https://github.com/fsprojects/fantomas/issues/372#issuecomment-442434500

It seems the VS Code extension is using fantomas CLI arguments (with a no in front) but the defaults from the API so the effect is the opposite.

Another solution could be to remove the no prefix (and adjust the behaviour accordingly). This may be more clear for users.

paolodellepiane commented 5 years ago

Thank you! I embraced your suggestion to remove the no prefix.

alfonsogarciacaro commented 5 years ago

Thanks for fixing and thanks a lot for the extension, it's incredibly useful! 🥇