Closed paoloricciuti closed 6 months ago
Latest commit: a513350efd99dc96ab4de6db6f6ece166d8e8ca6
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
This update introduces a significant enhancement to the handling of query parameters in SvelteKit applications, particularly focusing on improving the developer experience during prerendering. By adjusting the importation and usage of page stores and introducing a conditional assignment based on the build environment, the changes aim to address crashes related to accessing url.searchParams
during prerendering, ensuring a smoother build process.
File Path | Change Summary |
---|---|
src/lib/sveltekit-search-params.ts |
- Imported building flag and type { Page } - Renamed page to page_store - Added conditional assignment for page |
.changeset/seven-hounds-help.md |
- Introduced documentation for fixing prerendering issue by faking the page store during build |
Objective | Addressed | Explanation |
---|---|---|
Bug Description and Expected SSR Behavior (#67) | ✅ | |
Reproduction Steps (#67) | ❌ | The PR does not include steps to reproduce the issue, as it focuses on code changes. |
Error Logs and Environment (#67) | ❌ | The PR addresses the error indirectly through code changes but does not explicitly handle HTTP errors in configuration. |
🐰 Oh hark! A fix so bright and keen,
Through code and logic, now unseen.
Prerender woes, they fade away,
WithsearchParams
fixed, we say "Hooray!"
🌟 In SvelteKit lands, where bugs do roam,
A rabbit's work makes it feel like home.
🚀 So off we go, with code so spright,
To build, to dream, into the night.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Name | Link |
---|---|
Latest commit | a513350efd99dc96ab4de6db6f6ece166d8e8ca6 |
Latest deploy log | https://app.netlify.com/sites/sveltekit-search-params/deploys/65cf7a3df09f2100081aab15 |
Deploy Preview | https://deploy-preview-68--sveltekit-search-params.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Closes #67
Summary by CodeRabbit