Closed ErikMogensen closed 2 years ago
I don't have the bandwidth to check that everything works as expected and you are more knowledgeable than me in this area, so I trust your work and approve the PR 😄 @ErikMogensen @SeanFeldman
@ErikMogensen it's a draft because it's still a WIP PR or is it ready to be reviewed? Thanks.
@SeanFeldman, it is ready for review. I have now put it in 'Ready for review'.
Approved.
README.md will need to be updated to point to GitHub rather than AppVeyor.
@SeanFeldman, is there anything we should do with Appveyor before merging this PR? Otherwise let's merge it. I'll create a separate PR for the Readme.md.
AppVeyor project was deleted and won't interfere with GH Actions. Good to proceed 👍
Fixes #598
Replaces Appveyor and GitVersion with GitHub Actions.
It is using an ugly way of verifying that releases are only done from the master branch, see https://github.community/t/how-to-create-filter-on-both-tag-and-branch/16936/2).
I intend to wait with the publishing to Chocolatey until it has been verified that the publishing to GitHub works properly.
Since this is quite a change to the CI/CD system I'll wait for the go ahead from @paolosalvatori and @SeanFeldman before I make it ready for review.
Edit: Added branch check to the code since the initial PR.