search

paolosalvatori / ServiceBusExplorer

The Service Bus Explorer allows users to connect to a Service Bus namespace and administer messaging entities in an easy manner. The tool provides advanced features like import/export functionality or the ability to test topic, queues, subscriptions, relay services, notification hubs and events hubs.
MIT License
1.98k stars 577 forks source link

Sdk migration ServiceBus Queues #750

Open Merlijnv opened 7 months ago

Merlijnv commented 7 months ago

To make #607 possible we need to migrate the sdk's for servicebus, notificationhub and such to the new sdk. To make this possible I am going to start with servicebus queues

Merlijnv commented 7 months ago

@SeanFeldman the PR you asked for so that the issue is not filled with discussions about the implementatie and such

SeanFeldman commented 7 months ago

(I've marked the PR as a draft PR)

@Merlijnv, you're doing great 👍

Feel free to adopt or discard: you could go for a Centralized Package Management. Easier to control the versions required by projects.

Merlijnv commented 7 months ago

@SeanFeldman previous QueueDescription seems to be splitted up into 2 (QueueProperties and QueueRuntimeProperties) So I have to or choose 1 to use or retrieve both. What is your opinion on this?

SeanFeldman commented 7 months ago

@SeanFeldman previous QueueDescription seems to be splitted up into 2 (QueueProperties and QueueRuntimeProperties) So I have to or choose 1 to use or retrieve both. What is your opinion on this?

Not following.

You'll need both. If you want, you could introduce an abstraction, QueueProperties that would expose the information from the two new APIs.

Merlijnv commented 7 months ago

Not following.

* `QueueProperties` is necessary to provide the information about the queue and to be able to modify those.

* `QueueRuntimeProperties` is for the message counts.

Yeah but for example for the queue overview I only need QueueRuntimeProperties because that includes all the info for it. So I was thinking or always combine and have some extra info but also extra possible unneeded call. Or make seperate calls for if both, Properties or RuntimeProperties are needed. Idk what would be the impact of always using a combined call.

stale[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.