search

paolosalvatori / ServiceBusExplorer

The Service Bus Explorer allows users to connect to a Service Bus namespace and administer messaging entities in an easy manner. The tool provides advanced features like import/export functionality or the ability to test topic, queues, subscriptions, relay services, notification hubs and events hubs.
MIT License
1.98k stars 577 forks source link

UI doesn't scale correctly #784

Closed Splaxi closed 4 days ago

Splaxi commented 1 week ago

Using the latest release - on Windows 11, Microsoft Surface, the UI doesn't scale:

image

It seems that the right anchor isn't is configured correctly. The scroll bar doesn't show if I minimize to a non-full screen mode.

Is this by design?

maf-soft commented 1 week ago

Same here, and after "Set Default Layout", the Log area is completely out of the window and not reachable anymore.

I'm using a remote desktop connection - the client has normal FullHD and 100% scaling.

ErikMogensen commented 1 week ago

No, that's not the way it is supposed to look.

ErikMogensen commented 1 week ago

@Splaxi, @maf-soft I am unable to reproduce this.

  1. Are you using v6.0.0?
  2. Is it the same in 5.0.18?
  3. @splaxi, what is the Scale setting? It is under Settings | System > Display image
  4. Anything else you can think of that would cause this behavior?
maf-soft commented 1 week ago

Yes, I used choco to update from 5.0.18 (where it looked ok) to 6.0.0. It runs on a VM with WindowsServer 2022-datacenter-azure-edition, the RDP client is Win11.

maf-soft commented 1 week ago

Ah the client has multiple screens in my case. If I move the RDP window to the other screen, which has a scaling of 250%, the wrong proportions look exactly the same, just everything 250% larger.

Splaxi commented 1 week ago

Single monitor, zip file download directly from GitHub.

Not around my machine at the moment.

No issues in v5 - version was not the latest v5 though....

Splaxi commented 1 week ago

Okay.

Microsoft Surface Laptop 4, running directly on battery. No cables connected.

With scale set to 100% - it looks like this:

image

Settings are like this: image

Anything other than 100%, eg. 125/150% - yields the following result:

image

Settings are like this: image

Running any scale beyond 100%, with custom resolution settings (non-recommend), yields the same result. The edges on the right hand side and boxes doesn't look as it should.

jamesmanning commented 6 days ago

Just another data point - 250% scale, win11, screen resolution 3840x2400 - 5.0.18 looked fine, 6.0.0 results in 4.5 of the subscription modification buttons being cut off, no matter how wide I make the window. In my small amount of previous winforms experience, I usually had this issue when I needed to anchor things to the right side instead but I'm not sure what's the actual issue here.

image

ErikMogensen commented 5 days ago

It looks like someone was doing GUI changes using VS in DPI aware mode.

I believe I fixed it. If you are able to build it you can clone https://github.com/ErikMogensen/ServiceBusExplorer/tree/FixUiScaling and try that branch.

Otherwise you'll have to wait until it is released.

Splaxi commented 4 days ago

I can confirm the branch does in fact fix the issue.

It loads my current saved connections and scales as expected, regardless of what I throw at it.

Thanks for taking the time to look into it - Now the waiting begins 🤞

ErikMogensen commented 4 days ago

6.0.1 is now released, https://github.com/paolosalvatori/ServiceBusExplorer/releases/tag/6.0.1. It will take some time until it is available on Chocolatey.

Thanks for providing information and testing!

Splaxi commented 4 days ago

Thanks for the fast assistance.

I believe that you might need to bump the version of the exe file - to have the "New Version is available" notification to work properly 😉

image

ErikMogensen commented 4 days ago

Thanks for the warning. Version stamping is done automatically - if it works as it should...

In this case I think that you installed it using choco or scoop and got an old version. It seems that chocolatey takes a lot of time to update. The zip file on GitHub for version 6.0.1 contains an exe with a proper version number.

jamesmanning commented 2 days ago

@ErikMogensen FWIW, in noticing 6.0.1 hasn't shown up in winget yet, it appears that as it stands, someone runs the komac tool to submit a new version, as @Ancient77 did last week

https://github.com/microsoft/winget-pkgs/pull/159876

It also seems like there's a github action available that would help automate this to prevent people from having to take this manual step when new versions are published - is this (or some similar automation for publishing to winget) possibly an option for ServiceBusExplorer for future versions, please? 🙏

'manual' official option (AFAICT) https://github.com/microsoft/winget-create?tab=readme-ov-file#using-windows-package-manager-manifest-creator-in-a-cicd-pipeline

unofficial but likely easier to use github action? https://github.com/russellbanks/Komac?tab=readme-ov-file#usage-with-github-actions-winget-releaser-

It seems like this isn't needed for choco/scoop since those seem to have picked up 6.0.1 already. I'm a little surprised winget doesn't have some kind of automation on its own to pick up new releases from a github project, admittedly. Or maybe it does and there's something off with it? Not sure.

https://community.chocolatey.org/packages/ServiceBusExplorer https://github.com/ScoopInstaller/Extras/blob/master/bucket/servicebusexplorer.json