search

papacarp / pooltool.io

A public repo to keep track of issues and feature requests in pooltool
76 stars 75 forks source link

[BUG] - Variable fee display not consistent #149

Closed Straightpool closed 2 years ago

Straightpool commented 3 years ago

Area Variable fee column

Summary Pool fee adjustments take one epoch longer to become effective than stake changes. Pooltool does display the current effective fee and change marker correctly most of the time, but not consistently so. TBD: what pooltool actually shows needs to be validated, possibly pooltool visualizes at the current time the fee which will be effective if the delegator delegated right now? In this case the assumptions are wrong

Steps to reproduce Steps to reproduce the behavior:

  1. Create pool, set variable fee to Y and make sure it is tracked by pooltool.io
  2. Change variable fee to X>Y in epoch n-1 and back to Y in epoch n.
  3. Visit pooltool and track pool variable fee display in epoch n-1, n, n+1, n+2, n+3
  4. See error at least in epoch n, instead of displaying Y with an up arrow, pooltool already displays X with no change notification whatsoever

Expected behavior Pooltool always shows the current effective variable fee with change indications if something will change in an upcoming epoch In epoch n-1 pooltool shows variable fee Y with an up arrow In epoch n pooltool shows variable fee Y with an up arrow In epoch n+1 pooltool shows variable fee Y with an up arrow In epoch n+2 pooltool shows variable fee X with a down arrow In epoch n+3 pooltool shows variable fee Y (with no change arrow if no other change was submitted in between)

Screenshots and attachments This is in epoch n, fee was changed to X=4% in epoch n-1 and to Y=0% in epoch n: image -> Not-expected behavior

This is also epoch n, about middle of epoch: image -> Not-expected behavior, change in-between an epoch

This is epoch n+1 image -> Not-expected behavior, in epoch n+2 the effective variable fee changes to X, it shows Y without any change indicator

Additional context I believe in epoch n+1 and following pooltool does display this correctly, I will track this and update this issue epoch by epoch if I learn more.

Straightpool commented 2 years ago

Not enough data or validation, close for now