papaemmelab / toil_container

:whale: Toil + Docker and Singularity.
MIT License
9 stars 6 forks source link

Toil 5.x upgrade #31

Closed juanesarango closed 3 years ago

juanesarango commented 3 years ago

Following @multimeric contributions to upgrade toil_container to the latest toil version https://github.com/papaemmelab/toil_container/pull/29, this PR adds the following:

With contributions of @ddomenico

multimeric commented 3 years ago

Looks great!

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4dde66e). Click here to learn what that means. The diff coverage is 93.87%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage          ?   95.42%           
=========================================
  Files             ?        7           
  Lines             ?      350           
  Branches          ?        0           
=========================================
  Hits              ?      334           
  Misses            ?       16           
  Partials          ?        0           
Impacted Files Coverage Ξ”
toil_container/jobs.py 95.71% <88.46%> (ΓΈ)
toil_container/__init__.py 100.00% <100.00%> (ΓΈ)
toil_container/containers.py 98.09% <100.00%> (ΓΈ)
toil_container/parsers.py 100.00% <100.00%> (ΓΈ)
toil_container/utils.py 73.17% <100.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 4dde66e...7901682. Read the comment docs.

multimeric commented 3 years ago

It's worth noting that toil just merged the addBatchSystemFactory function as a public API again: https://github.com/DataBiosphere/toil/pull/3754. So we can revert one of my changes and go back to using it as soon as it's published. Could be done in a separate PR though.

juanesarango commented 3 years ago

@multimeric yes, I can roll back those changes. Will do this when toil makes a new release with the changes. Thanks for asking the toil team to add this back!