papampi / nvOC_by_fullzero_Community_Release

nvOC free-easy-to-use Linux Nvidia Mining OS, Community Release
GNU General Public License v3.0
39 stars 23 forks source link

NICE_"some algo" not working correctly #88

Closed pegga closed 6 years ago

pegga commented 6 years ago

Hi guys,

1) NICEEQUIHASH, ETHASH, etc are not working for me. Miner keeps restarting. Log shown invalid parameters for miner (actually epty parameters). It helped me to unify NICE... and NICE-... which are used in 1bash and 0miner. After change from NICE-... to NICE_... miners are working well (some).

2) NICE_... mining options are not working together with WTM_SWITCHING. I assume there is problem with parsing JSON for these, sice it does not contain directly name of the coin. I have to check WTM_SWITCHING option and how it works.

3) TPccminer does not work for me for lyra2rev2. I tried NICE_LYRA2REV2. Miner keeps restarting without much mentioned in screen log. Tried ASccminer and this one seems to work well. Any suggestions on what to check?

LuKePicci commented 6 years ago

WTM uses NICE-... to identify algorithms, so anything in nvOC should refer to NICE-... I've not looked into nicehash support but if you are able to understand why using NICE_ instead of NICE- resolve your issue number 1) please report. Meanwhile @papampi should take care of this.

pegga commented 6 years ago

as far as I understand, there is mixture of - and _ which causes problems. Coin is called NICE-..., but params for miner like NICE_EQUIHASH_POOL="equihash.eu.nicehash.com" NICE_EQUIHASH_PORT="3357" NICE_EQUIHASHWORKER="$WORKERNAME" use as you can see. This is problem when composing variable names in 0miner. Of course it can be unified to NICE-... too. Why not. I will try to do it tomorrow.

sizzlephizzle commented 6 years ago

For the record, I did preach that NICE- is not callable in bash. It breaks the variable.

To fix, I think you will need to find any reference to NICE- and replace with NICE_ Except in MPH where the conversion to NICE- Should occur.

Siz

On Wed, 6 Jun 2018, 22:00 pegga, notifications@github.com wrote:

as far as I understand, there is mixture of - and _ which causes problems. Coin is called NICE-..., but params for miner like NICE_EQUIHASH_POOL="equihash.eu.nicehash.com" NICE_EQUIHASH_PORT="3357" NICE_EQUIHASHWORKER="$WORKERNAME" use as you can see. This is problem when composing variable names in 0miner. Of course it can be unified to NICE-... too. Why not. I will try to do it tomorrow.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/papampi/nvOC_by_fullzero_Community_Release/issues/88#issuecomment-395212310, or mute the thread https://github.com/notifications/unsubscribe-auth/AiaWrWyzNeK4Xlws1QjMNRt9CeGDne5Bks5t6EL8gaJpZM4UdQUU .

papampi commented 6 years ago

@pegga Can you please check and test NICE fix PR #89 and see if it works or not As you noticed there was a mix settings of NICE- and NICE_, they should be fixed.

papampi commented 6 years ago

It looks like wtm switcher should work too

BTC PRICE: 7691.0 USD
NICE_ETHASH 3.81 USD
NICE_CRYPTONIGHTV7 3.53 USD
ZCL 3.42 USD
NICE_EQUIHASH 3.18 USD
ZEN 3.06 USD
XVG 3.04 USD
BTX 2.92 USD
VTC 2.88 USD
KMD 2.88 USD
EXP 2.84 USD
MUSIC 2.82 USD
BSD 2.56 USD
GBX 1.67 USD
VIVO 1.52 USD
New profits
NICE_ETHASH: 103 %
NICE_CRYPTONIGHTV7: 96 %
ZCL: 93 %
NICE_EQUIHASH: 86 %
ZEN: 83 %
XVG: 83 %
BTX: 79 %
VTC: 78 %
KMD: 78 %
EXP: 77 %
MUSIC: 77 %
BSD: 70 %
GBX: 45 %
VIVO: 41 %
LuKePicci commented 6 years ago

@sizzlephizzle so it is mph and not wtm which uses nice- instead of nice_ ?

papampi commented 6 years ago

lol ... mph not use nice at all ... I'm sure it was a mistake.

LuKePicci commented 6 years ago

Sure... that was quite strange tbh

sizzlephizzle commented 6 years ago

Yeah sorry, WTM not mph. Knew it was one of the three letter acronyms haha.

Sorry folks.

Still, bash/shell cannot call $NICE-Anything because the hypen breaks the variable.

On Wed, 6 Jun 2018, 22:53 Luca Piccirillo, notifications@github.com wrote:

Sure... that was quite strange tbh

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/papampi/nvOC_by_fullzero_Community_Release/issues/88#issuecomment-395226176, or mute the thread https://github.com/notifications/unsubscribe-auth/AiaWrcZ8A8eQEclTLqrYF1vtQdrlhgtRks5t6E9WgaJpZM4UdQUU .

LuKePicci commented 6 years ago

I think you can use ${var-name} to fix this

Da: sizzlephizzle Inviato: giovedì 7 giugno 2018 00:48 A: papampi/nvOC_by_fullzero_Community_Release Cc: Luca Piccirillo; Comment Oggetto: Re: [papampi/nvOC_by_fullzero_CommunityRelease] NICE"some algo" notworking correctly (#88)

Yeah sorry, WTM not mph. Knew it was one of the three letter acronyms haha.

Sorry folks.

Still, bash/shell cannot call $NICE-Anything because the hypen breaks the variable.

On Wed, 6 Jun 2018, 22:53 Luca Piccirillo, notifications@github.com wrote:

Sure... that was quite strange tbh

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/papampi/nvOC_by_fullzero_Community_Release/issues/88#issuecomment-395226176, or mute the thread https://github.com/notifications/unsubscribe-auth/AiaWrcZ8A8eQEclTLqrYF1vtQdrlhgtRks5t6E9WgaJpZM4UdQUU .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

papampi commented 6 years ago

But if wtm works with PR #89, wouldn't it be better to all be the same with underscore? I can't test NICE, so if anyone can test please do.

LuKePicci commented 6 years ago

But if wtm works with PR #89, wouldn't it be better to all be the same with underscore?

Of course

papampi commented 6 years ago

@pegga PR #89 is waiting for your test and approval, Please check and let us know.

pegga commented 6 years ago

it works!

any comments on "TPccminer does not work for me for lyra2rev2" - I tried NICE_LYRA2REV2 to be specific

papampi commented 6 years ago

Whats the error? Whats the miner start command line?

pegga commented 6 years ago

SCREEN -c /home/m1/NVOC/testing/screenrc-miner -dmSL miner /home/m1/NVOC/testing/miners/TPccminer/ccminer -a lyra2v2 -o stratum+tcp://lyra2rev2.eu.nicehash.com:3347 -u MYBTCADDRESS.102 -p x -i

...MYBTCADDRESS is substitute for my address I cannot even see miner start. this the only thing I see in the log file. Is there some more to check? I am in remote connection right now.

LuKePicci commented 6 years ago

Try running TPccminer directly with the same command line you reported but outside of screen, see what happens.

papampi commented 6 years ago

Run it from a guake tab and check the error message /home/m1/NVOC/testing/miners/TPccminer/ccminer -a lyra2v2 -o stratum+tcp://lyra2rev2.eu.nicehash.com:3347 -u MYBTCADDRESS.102 -p x -i