search

papampi / nvOC_miners

nvOC easy-to-use Linux Nvidia Mining OS Miners
8 stars 7 forks source link

3.1-miners testing #30

Closed delawr0190 closed 5 years ago

delawr0190 commented 5 years ago

Using this to keep track of my testing of the 3.1 release. There will also be a corresponding PR onto the main nvOC repo for 1bash edits once I'm done.

Passed:

BMINER: 10.7.0 BMINER: 13.0.0 CLAYMORE: 11.9 CLAYMORE: 12.0 CryptoDredge: 0.14.0 CryptoDredge: 0.16.1 DSTM: 0.6.2 ETHMINER: 0.14 ETHMINER: 0.15 ETHMINER: 0.16 EWBF: 0.3.4b GMINER: 1.15 LOLMINER: 0.43 PhoenixMiner: 3.5d T_Rex: 0.8.8 T_Rex: 0.9.1 TPccminer: 2.3 (after recompile) XMR_Stak: 2.5.2 Z_EWBF: 0.6 ZENEMYminer: 1.28

Failed:

ENERGIMINER: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.22' not found (required by ./energiminer)

papampi commented 5 years ago

Fot GMiner, Z_EWBF, ... and zhash coins its better to use coin_extension_arguments, so you dont need to change miner_opts every time you want to switch coin. BTG example: BTG_EXTENSION_ARGUMENTS="--algo 144_5 --pers BgoldPoW"

papampi commented 5 years ago

So you tested manifests with MINER_OPTS and COIN__EXTENSION_ARGUMENTS variables, you want test again without them or I just remove all?

LuKePicci commented 5 years ago

I needed to define GMINER_OPTS in 1bash - I used "--algo 144_5 --pers ZelProof" - this probably isn't maintainable - seems like a mapping is needed somewhere.

Either we save such arguments in 1bash for coin_opts as @papampi correctly suggested, or we implement such mapping in the miner wrapper. For example (thank you for recalling this otherwise I would have forgotten) this if block for XMR_Stak https://github.com/papampi/nvOC_by_fullzero_Community_Release/blob/52b858996e0bdb8ea51eb69bc6c78398cd2c65e5/0miner#L320 needs to be added into https://github.com/papampi/nvOC_miners/blob/3.1-miners/XMR_Stak/2.5.2/xmr-stak.nvoc.sh for almost the same reasons.

LuKePicci commented 5 years ago

So you tested manifests with MINER_OPTS and COIN__EXTENSION_ARGUMENTS variables, you want test again without them or I just remove all?

I removed already xext and opts from some spare manifests I tested long time ago, including those one he tested, and _EXTENSION_ARGUMENTS variables do not appear anymore in 1bash so whatever he tested via *_OPTS is still valid. That's why @delawr0190 noticed $OPTS had to be removed from EWBF hcd, I guess, otherwise he was getting duplicate arguments.

delawr0190 commented 5 years ago

Yes, I was seeing duplicated args.

I’ll restart my testing with these new changes in place. 👍🏻

papampi commented 5 years ago

I say we merge these changes to 3.1-dev, but keep this PR open for more testing and editing.

LuKePicci commented 5 years ago

Last time I tried doing something similar github tricked me and closed the PR automatically...

delawr0190 commented 5 years ago

I’ll have these all done within 2 days, so we can leave it open, if possible, so that doesn’t happen. 🙏🏻

Also, who is going to address the mappings for gminer? I can, but I’m still not that familiar with nvOC so whatever I do is probably gonna need to be cleaned up. I can churn through the testing while somebody else adds the mappings. Please.

papampi commented 5 years ago

You can open it again after making more changes to the branch, cant you?

papampi commented 5 years ago

@delawr0190 GMiner works with no problem, you just need to add "--algo" and " --pers " to COIN_OPTS for GMINER, Z_EWBF for ZHASH coins

delawr0190 commented 5 years ago

It seems like it could be made easier to use if we did something like what @LuKePicci mentioned above for xmrstak.

$ALGO and $COIN are already defined. We have everything that’s needed, I believe, to generate —algo and —pers for the user without requiring that they sprinkle more opts throughout 1bash.

Maybe? I don’t run gminer so not entirely sure what all goes into it. Just trying to make it easier to use if possible.

papampi commented 5 years ago

Every day new shitcoins and new algos pops out, then we should keep editing and editing,so users dont do anything ... I'm good if you guys like to make it more simple for users ;)

papampi commented 5 years ago

I cant make the Z_EWBF to mine and it wont start. Any ideas?

papampi commented 5 years ago

All looks good in its folder too:

m1@m1-desktop:~$ ll NVOC/dev/miners/Z_EWBF/0.6/
total 1796
drwxrwxr-x 2 m1 m1    4096 Jan 23 01:44 ./
drwxrwxr-x 3 m1 m1    4096 Jan 23 01:44 ../
-rwxr-xr-x 1 m1 m1 1532744 Sep 29 19:34 miner*
-rwxr-xr-x 1 m1 m1     771 Jul 17  2018 miner.cfg*
-rw-rw-r-- 1 m1 m1    1057 Jan 23 01:44 .nvoc-miner.json
-rw-rw-r-- 1 m1 m1    1057 Jan 23 01:44 nvoc-miner.json
-rw-rw-r-- 1 m1 m1       5 Oct  2 13:17 version
-rw-rw-r-- 1 m1 m1  274520 Jan 20 19:37 z_ewbf_v0.6.tar.xz

m1@m1-desktop:~$ ll NVOC/dev/miners/Z_EWBF/latest/
total 1796
drwxrwxr-x 2 m1 m1    4096 Jan 23 01:44 ./
drwxrwxr-x 3 m1 m1    4096 Jan 23 01:44 ../
-rwxr-xr-x 1 m1 m1 1532744 Sep 29 19:34 miner*
-rwxr-xr-x 1 m1 m1     771 Jul 17  2018 miner.cfg*
-rw-rw-r-- 1 m1 m1    1057 Jan 23 01:44 .nvoc-miner.json
-rw-rw-r-- 1 m1 m1    1057 Jan 23 01:44 nvoc-miner.json
-rw-rw-r-- 1 m1 m1       5 Oct  2 13:17 version
-rw-rw-r-- 1 m1 m1  274520 Jan 20 19:37 z_ewbf_v0.6.tar.xz
LuKePicci commented 5 years ago

Is the resulting command line correct?

papampi commented 5 years ago

Not shows up the started miner command

Z_EWBF:

DISABLED_GPUS not set
/home/m1/NVOC/dev/0miner: line 191: eval: --: invalid option
eval: usage: eval [arg ...]
screen -c /home/m1/NVOC/dev/screenrc-miner -dmSL miner /home/m1/NVOC/dev/miners/Z_EWBF/0.6/miner --fee 0 --server ${!xpool} --user ${!xaddr}${!xwallet}${!xwork} --pass $MINER_PWD --port ${!xport} $Z_EWBF_OPTS ${!xext}

Miner output: ./nvOC miner-log

Z-ENEMY:

LAUNCHING:  MINER (coin: RVN, algo: X16R)

DISABLED_GPUS not set
/home/m1/NVOC/dev/0miner: line 191: eval: --: invalid option
eval: usage: eval [arg ...]
screen -c /home/m1/NVOC/dev/screenrc-miner -dmSL miner /home/m1/NVOC/dev/miners/ZENEMYminer/latest/z-enemy $UCCALGO -o ${!xproto}://${!xpool}:${!xport} -u ${!xaddr}${!xwallet}${!xwork} -p $MINER_PWD -i ${!xintensity} $CCMINER_OPTS ${!xext}

    SCREEN -c /home/m1/NVOC/dev/screenrc-miner -dmSL miner /home/m1/NVOC/dev/miners/ZENEMYminer/latest/z-enemy -a x16r -o stratum+tcp://rvn.suprnova.cc:6667 -u papampi.nv100 -p x -i 0

Miner output: ./nvOC miner-log
papampi commented 5 years ago

ZEL Coin with Z_EWBF:

LAUNCHING:  MINER (coin: ZEL, algo: ZHASH)

DISABLED_GPUS not set
/home/m1/NVOC/dev/0miner: line 191: eval: --: invalid option
eval: usage: eval [arg ...]
screen -c /home/m1/NVOC/dev/screenrc-miner -dmSL miner /home/m1/NVOC/dev/miners/Z_EWBF/0.6/miner --fee 0 --server ${!xpool} --user ${!xaddr}${!xwallet}${!xwork} --pass $MINER_PWD --port ${!xport} $Z_EWBF_OPTS ${!xext}

Miner output: ./nvOC miner-log
papampi commented 5 years ago

Removed $Z_EWBF_OPTS and ${!xext} from manifest and still no go ...

LuKePicci commented 5 years ago

Got it, now fixing. Does ethminer 0.16.0 gives the same error too?

papampi commented 5 years ago

Dont think so, let me check again

papampi commented 5 years ago

Ethminer is ok:

LAUNCHING:  MINER (coin: ELLA, algo: ETHASH)

DISABLED_GPUS not set
/home/m1/NVOC/dev/0miner: line 191: eval: --: invalid option
eval: usage: eval [arg ...]
screen -c /home/m1/NVOC/dev/screenrc-miner -dmSL miner /home/m1/NVOC/dev/miners/ETHMINER/latest/ethminer -P ${!xproto}://${!xaddr}${!xwallet}${!xwork}:$MINER_PWD@${!xpool}:${!xport} -U

    SCREEN -c /home/m1/NVOC/dev/screenrc-miner -dmSL miner /home/m1/NVOC/dev/miners/ETHMINER/latest/ethminer -P stratum1+tcp://MY_ADDRESS.nv100:x@ella.2miners.com:3030 -U

Miner output: ./nvOC miner-log

    SCREEN -c /home/m1/NVOC/dev/screenrc-miner -dmSL miner /home/m1/NVOC/dev/miners/ETHMINER/latest/ethminer -P stratum1+tcp://MY_ADDRESS.nv100:x@ella.2miners.com:3030 -U
 m 18:35:10 ethminer ethminer 0.16.0
 m 18:35:10 ethminer Build: linux/release
cu 18:35:10 ethminer Using grid size: 8,192, block size: 128
 i 18:35:10 ethminer Configured pool ella.2miners.com:3030
 i 18:35:10 main     Selected pool ella.2miners.com:3030
 i 18:35:10 stratum  Stratum mode detected: ETHPROXY Compatible
LuKePicci commented 5 years ago

I will now fix that error in the eval, and add than we check again if this occurs.

papampi commented 5 years ago

Got it, ZEL_OPTS variable not passing, but Z_EWBF_OPTS passes. Some thing is missing for COIN_OPTS in 0miner

delawr0190 commented 5 years ago

I put together a testing framework to help with some of the changes (I was running them by hand, but there are so many changes daily that it got to the point where I had to re-run them and it takes so long). You guys are welcome to use it if you find it useful.

I'm currently adding tests as I go for each miner. I should have them all added and able to be continuously tested within another day or so. Still building the tests out, but it's making it a lot easier.

https://github.com/delawr0190/foreman-nvoc-ci

LuKePicci commented 5 years ago

Sounds like this will be the most stable beta ever 😆

delawr0190 commented 5 years ago

I finished my testing of 3.1. I pushed my changes to this branch that will fix the miners and their integration with Foreman.

There are a couple of problems that remain, though, and I'm not entirely sure how you guys want to address them:

  1. anxccminer is not a phi2 miner, but it's the default phi2 miner in 1bash.
  2. vertminer throws an 'illegal instruction' error when it's ran.
  3. tpccminer throws an 'illegal instruction' error when it's ran.
  4. silentminer depends on cuda 9.1, which isn't available.
  5. naccminer throws an 'illegal instruction' error when it's ran.
  6. ktccminer throws an 'illegal instruction' error when it's ran.
  7. ktccminer_cryptonight depends on cuda 9.1, which isn't available.
  8. energiminer: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.22' not found (required by ./energiminer).
  9. xmrstak is missing a symlink after install to recommended.
  10. once the symlink is fixed, xmrstak throws error while loading shared libraries: libmicrohttpd.so.12: cannot open shared object file: No such file or directory

I'm using the default 3.1 install with no extra dependencies or anything, and the 3.1 miners branch. I'm not entirely sure if the illegal instruction errors are specific to my setup, but I'm using the base load and they seem to be happening.

LuKePicci commented 5 years ago

You should be able to solve most 'illegal instruction' errors by recompiling those miners. Same for those two which depends on cuda-9.1, however you should also be able to run them with a 9.2 runtime. Please confirm. Will check the missing symlink. Also xmr-stak needs to be recompiled to depend on the libmicrohttpd version of your system, which is different between ubuntu 16 and 18. I don't know anything about energiminer, will wait info from @papampi on this and let him choose another miner for phi2. Thanks for the exhaustive reporting. Are you on the ubuntu18 or ubuntu16 image? 18 I guess...

delawr0190 commented 5 years ago

I'm on 16.04.5 LTS.

When 3.1 is released and a new image is released, will the miners all be compiled for the release? Want to make sure that users don't need to recompile as soon as they install. I don't remember seeing that as part of the setup process when I first setup 3.0 on my test machine.

LuKePicci commented 5 years ago

As far as I know you always need to recompile them if your architecture is different from the one used by @papampi for compiling. I mean, at least for the illegal instruction error. Probably something related to their CPU-mining capability. If you didn't have to recompile after 3.0 install on ubuntu 16, you probably won't need to recompile on a 3.1 install over the same image on the same machine, assuming you select the same miner versions set.

delawr0190 commented 5 years ago

I think my compiled version of miners got lost when I was doing some branch switching. That could be what happened there.

Going to recompile now and try them again. Will let you know.

delawr0190 commented 5 years ago

I was able to get some miners to recompile, and for those, I updated my first post.

Current remaining issues:

ENERGIMINER: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.22' not found (required by ./energiminer) KTccminer: illegal instruction (following a recompile, I couldn't get this to stop crashing) KTccminer_cryptonight: illegal instruction (recompile doesn't exist in nvoc script) SILENTminer: cuda 9.1 (no source?) SP_SUPRminer: folder only has 2 files in it? XMR_Stak: missing 'recommended' symlink and libmicrohttpd.so (src folder is empty - can't recompile)

LuKePicci commented 5 years ago

If you are on a cuda-10 machine you won't get any "recommended" symlink for xmr-stak since the latest included version, 2.5.2, gets recommended for cuda-9.2. If you're on cuda-9.2 there were still some issues with cuda version strings in some other manifests I just fixed globally. - xmr-stak was one of them. SP_SUPRminer is clearly broken. Not sure what happened. it probably got renamed and we lost something behind. SILENTminer is closed-source, but you should be able to run that even on 9.2 without issues: if it doesn't, we will just change it to recommended on cuda 9.1. Regarding KTccminer, check that its binary actually gets replaced by the compilation output. Finally, both KTccminer_cryptonight and XMR_Stak gets compiled by instructions from pm manifest. I just found a potential issue with miners existing in multiple versions when compiler script is asked to compile them all, I should have effectively addressed such situations either with my last commit. Let me know if you have further issues with those last two.

delawr0190 commented 5 years ago

I'm using cuda 9.2 and for xmrstak, it seems like the recommended version is getting set to 2.5.1. Is that correct?

Also, where does the recompilation of xmrstak end up happening? The nvoc script in the miners repo, when you select to recompile, doesn't list xmrstak or ktccminer_cryptonight. It looks like it used to in the 3.0-miners branch, though. Is there a reason why these were removed, and if so, is there something that I'm supposed to be doing to trigger their compilation?

Switching to cuda 9.1 - I'm still not THAT familiar with nvOC yet, but I don't see how that fixes the problem of it not running. In my /usr/local, my link is pointing to cuda-9.2. I'm trying to run SILENTminer, but it just says that it's missing libcudart.so.9.1. I only see 1.10 - is there a 9.2 version somewhere that it should be using instead? The only cuda versions that I'm seeing a 8.0 and 9.2.

Regarding ktccminer, I pulled your changes and did a fresh recompile. I'm still getting this:

[2019-01-27 06:21:09] Stratum difficulty set to 32
[2019-01-27 06:21:09] Received new neoscrypt block header
[2019-01-27 06:21:09] block height 238575, 1 transactions
[2019-01-27 06:21:13] GPU #0: using default intensity 14.000
[2019-01-27 06:21:13] GPU #2: using default intensity 14.000
[2019-01-27 06:21:13] GPU #1: using default intensity 14.000
*** Error in `./ccminer': free(): invalid pointer: 0x00007f645ae4b6f8 ***
======= Backtrace: =========
/lib/x86_64-linux-gnu/libc.so.6(+0x777e5)[0x7f646989d7e5]
/lib/x86_64-linux-gnu/libc.so.6(+0x8037a)[0x7f64698a637a]
/lib/x86_64-linux-gnu/libc.so.6(cfree+0x4c)[0x7f64698aa53c]
./ccminer[0x413298]
./ccminer[0x409ab0]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x76ba)[0x7f646ab346ba]
/lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x7f646992d41d]

Seems like this miner isn't working.

LuKePicci commented 5 years ago

Recommended xmr-stak for 9.2 is 2.5.2, but there was still an outdated recommendation flag set into the rpevious one, just fixed this. Please check that the install script creates the right symlink now. Remember to remove the non-hidden manifest of 2.5.2 to trigger a reinstall, and let it rebuild the symlink.

As compiled by PM instructions, you should input their full name at the prompt. If you input "1,R,XMR_Stak/2.5.2,KTccminer_cryptonight" it should recompile ASccminer and MSFTccminer with legacy compiler scripts, XMR_Stak version 2.5.2 and all KTccminer_cryptonight versions following PM compile directives. I just finished including dynamically also PM compilers in that list.

delawr0190 commented 5 years ago

Seems like there are other issues now, and it still isn't listing the other miners.

A - Compile ALL opensouce miners
E - Exit and do not compile anything

1 - ASccminer
2 - KTccminer
4 - KXccminer
5 - NAccminer
6 - SPccminer
7 - TPccminer
8 - VERTMINER
9 - ANXccminer
C - cpuminer
R - MSFTccminer (RVN)
U - SUPRminer

jq: error: Could not open file /home/m1/NVOC/mining/miners/BMINER/10.7.0/nvoc-miner.json
/home/m1/NVOC/mining/miners/BMINER/13.0.0/nvoc-miner.json
/home/m1/NVOC/mining/miners/CLAYMORE/12.0/nvoc-miner.json
/home/m1/NVOC/mining/miners/CLAYMORE/11.9/nvoc-miner.json
/home/m1/NVOC/mining/miners/CryptoDredge/0.16.1/nvoc-miner.json
/home/m1/NVOC/mining/miners/CryptoDredge/0.14.0/nvoc-miner.json
/home/m1/NVOC/mining/miners/DSTM/0.6.2/nvoc-miner.json
/home/m1/NVOC/mining/miners/ENERGIMINER/2.2.1/nvoc-miner.json
/home/m1/NVOC/mining/miners/ETHMINER/0.15.0/nvoc-miner.json
/home/m1/NVOC/mining/miners/ETHMINER/0.16.0/nvoc-miner.json
/home/m1/NVOC/mining/miners/ETHMINER/0.14.0/nvoc-miner.json
/home/m1/NVOC/mining/miners/EWBF/0.3.4b/nvoc-miner.json
/home/m1/NVOC/mining/miners/GMINER/1.15/nvoc-miner.json
/home/m1/NVOC/mining/miners/KTccminer_cryptonight/3.05/nvoc-miner.json
/home/m1/NVOC/mining/miners/KTccminer_cryptonight/2.06/nvoc-miner.json
/home/m1/NVOC/mining/miners/T_Rex/0.9.1/nvoc-miner.json
/home/m1/NVOC/mining/miners/T_Rex/0.8.8/nvoc-miner.json
/home/m1/NVOC/mining/miners/XMR_Stak/2.5.2/nvoc-miner.json
/home/m1/NVOC/mining/miners/XMR_Stak/2.4.7/nvoc-miner.json
/home/m1/NVOC/mining/miners/XMR_Stak/2.4.4/nvoc-miner.json
/home/m1/NVOC/mining/miners/XMR_Stak/2.5.1/nvoc-miner.json
/home/m1/NVOC/mining/miners/ZENEMYminer/1.28/nvoc-miner.json
/home/m1/NVOC/mining/miners/Z_EWBF/0.6/nvoc-miner.json: No such file or directory
jq: error: Could not open file /home/m1/NVOC/mining/miners/BMINER/10.7.0/nvoc-miner.json
/home/m1/NVOC/mining/miners/BMINER/13.0.0/nvoc-miner.json
/home/m1/NVOC/mining/miners/CLAYMORE/12.0/nvoc-miner.json
/home/m1/NVOC/mining/miners/CLAYMORE/11.9/nvoc-miner.json

Getting:

jq: error: Could not open file /home/m1/NVOC/mining/miners/BMINER/10.7.0/nvoc-miner.json
/home/m1/NVOC/mining/miners/Z_EWBF/0.6/nvoc-miner.json: No such file or directory
(multiple comma separated values, example: 1,6,R,/home/m1/NVOC/mining/miners/BMINER/10.7.0/nvoc-miner.json
delawr0190 commented 5 years ago

XMR_Stak is running now, though.

Getting this when it starts, and then it hangs:

SCREEN -c /home/m1/NVOC/mining/screenrc-miner -dmSL miner /home/m1/NVOC/mining/miners/XMR_Stak/recommended/xmr-stak.nvoc.sh --config /config.txt --poolconf /pools.txt --nvidia /nvidia.txt --currency monero --noCPU --noAMD -o xmr.2miners.com:2222 -u 4B1hCWuXLRh5HRts6qzB88MnDgCC6JoPk9LNtkWSf9whL7it1CVXWXmjh5AheEEDzHC7PSDm5VKiL8pG4jJD9Y7vGJuxexC.1050 -p x -i 0 --httpd 3333
vm.nr_hugepages = 128
Configuration stored in file '/config.txt'
Please enter:
LuKePicci commented 5 years ago

Not sure why it had problems working with full paths, anyway now should print relative ones instead. Also xmr-stak should seek for config file in the right place now, but I don't know if it creates default ones by itself or still need to be run manually for the first time to create them.

delawr0190 commented 5 years ago

It seems like the script is now generating broken links for every miner. Here's an example:

m1@m1-desktop:~/NVOC/mining/miners$ ll BMINER/
total 16
drwxrwxr-x  4 m1 m1 4096 Jan 27 19:57 ./
drwxrwxr-x 31 m1 m1 4096 Jan 27 19:54 ../
drwxrwxr-x  2 m1 m1 4096 Jan 27 19:57 10.7.0/
drwxrwxr-x  2 m1 m1 4096 Jan 27 19:57 13.0.0/
lrwxrwxrwx  1 m1 m1   16 Jan 27 19:57 latest -> ./BMINER/13.0.0/
lrwxrwxrwx  1 m1 m1   16 Jan 27 19:57 recommended -> ./BMINER/13.0.0/
m1@m1-desktop:~/NVOC/mining/miners$

I think that the script is also still not searching for those json files correctly. Here's the output I get to the console when I run it - it looks like it's dumping more than we'd expect:

Reading package lists... Done
Building dependency tree
Reading state information... Done
cmake is already the newest version (3.5.1-1ubuntu3).
0 upgraded, 0 newly installed, 0 to remove and 5 not upgraded.
Reading package lists... Done
Building dependency tree
Reading state information... Done
0 upgraded, 0 newly installed, 0 to remove and 5 not upgraded.
Miners to compile:

A - Compile ALL opensouce miners
E - Exit and do not compile anything

1 - ASccminer
2 - KTccminer
4 - KXccminer
5 - NAccminer
6 - SPccminer
7 - TPccminer
8 - VERTMINER
9 - ANXccminer
C - cpuminer
R - MSFTccminer (RVN)
U - SUPRminer

~/NVOC/mining/miners ~/NVOC/mining/miners
jq: error: Could not open file ./BMINER/10.7.0/nvoc-miner.json
./BMINER/13.0.0/nvoc-miner.json
./CLAYMORE/12.0/nvoc-miner.json
./CLAYMORE/11.9/nvoc-miner.json
./CryptoDredge/0.16.1/nvoc-miner.json
./CryptoDredge/0.14.0/nvoc-miner.json
./DSTM/0.6.2/nvoc-miner.json
./ENERGIMINER/2.2.1/nvoc-miner.json
./ETHMINER/0.15.0/nvoc-miner.json
./ETHMINER/0.16.0/nvoc-miner.json
./ETHMINER/0.14.0/nvoc-miner.json
./EWBF/0.3.4b/nvoc-miner.json
./GMINER/1.15/nvoc-miner.json
./KTccminer_cryptonight/3.05/nvoc-miner.json
./KTccminer_cryptonight/2.06/nvoc-miner.json
./T_Rex/0.9.1/nvoc-miner.json
./T_Rex/0.8.8/nvoc-miner.json
./XMR_Stak/2.5.2/nvoc-miner.json
./XMR_Stak/2.4.7/nvoc-miner.json
./XMR_Stak/2.4.4/nvoc-miner.json
./XMR_Stak/2.5.1/nvoc-miner.json
./ZENEMYminer/1.28/nvoc-miner.json
./Z_EWBF/0.6/nvoc-miner.json: No such file or directory
jq: error: Could not open file ./BMINER/10.7.0/nvoc-miner.json
./BMINER/13.0.0/nvoc-miner.json
./CLAYMORE/12.0/nvoc-miner.json
./CLAYMORE/11.9/nvoc-miner.json
./CryptoDredge/0.16.1/nvoc-miner.json
./CryptoDredge/0.14.0/nvoc-miner.json
./DSTM/0.6.2/nvoc-miner.json
./ENERGIMINER/2.2.1/nvoc-miner.json
./ETHMINER/0.15.0/nvoc-miner.json
./ETHMINER/0.16.0/nvoc-miner.json
./ETHMINER/0.14.0/nvoc-miner.json
./EWBF/0.3.4b/nvoc-miner.json
./GMINER/1.15/nvoc-miner.json
./KTccminer_cryptonight/3.05/nvoc-miner.json
./KTccminer_cryptonight/2.06/nvoc-miner.json
./T_Rex/0.9.1/nvoc-miner.json
./T_Rex/0.8.8/nvoc-miner.json
./XMR_Stak/2.5.2/nvoc-miner.json
./XMR_Stak/2.4.7/nvoc-miner.json
./XMR_Stak/2.4.4/nvoc-miner.json
./XMR_Stak/2.5.1/nvoc-miner.json
./ZENEMYminer/1.28/nvoc-miner.json
./Z_EWBF/0.6/nvoc-miner.json: No such file or directory
BMINER/10.7.0/nvoc-miner.json
BMINER/13.0.0/nvoc-miner.json
CLAYMORE/12.0/nvoc-miner.json
CLAYMORE/11.9/nvoc-miner.json
CryptoDredge/0.16.1/nvoc-miner.json
CryptoDredge/0.14.0/nvoc-miner.json
DSTM/0.6.2/nvoc-miner.json
ENERGIMINER/2.2.1/nvoc-miner.json
ETHMINER/0.15.0/nvoc-miner.json
ETHMINER/0.16.0/nvoc-miner.json
ETHMINER/0.14.0/nvoc-miner.json
EWBF/0.3.4b/nvoc-miner.json
GMINER/1.15/nvoc-miner.json
KTccminer_cryptonight/3.05/nvoc-miner.json
KTccminer_cryptonight/2.06/nvoc-miner.json
T_Rex/0.9.1/nvoc-miner.json
T_Rex/0.8.8/nvoc-miner.json
XMR_Stak/2.5.2/nvoc-miner.json
XMR_Stak/2.4.7/nvoc-miner.json
XMR_Stak/2.4.4/nvoc-miner.json
XMR_Stak/2.5.1/nvoc-miner.json
ZENEMYminer/1.28/nvoc-miner.json
Z_EWBF/0.6      -
~/NVOC/mining/miners

  (multiple comma separated values, example: 1,6,R,BMINER/10.7.0/nvoc-miner.json
BMINER/13.0.0/nvoc-miner.json
CLAYMORE/12.0/nvoc-miner.json
CLAYMORE/11.9/nvoc-miner.json
CryptoDredge/0.16.1/nvoc-miner.json
CryptoDredge/0.14.0/nvoc-miner.json
DSTM/0.6.2/nvoc-miner.json
ENERGIMINER/2.2.1/nvoc-miner.json
ETHMINER/0.15.0/nvoc-miner.json
ETHMINER/0.16.0/nvoc-miner.json
ETHMINER/0.14.0/nvoc-miner.json
EWBF/0.3.4b/nvoc-miner.json
GMINER/1.15/nvoc-miner.json
KTccminer_cryptonight/3.05/nvoc-miner.json
KTccminer_cryptonight/2.06/nvoc-miner.json
T_Rex/0.9.1/nvoc-miner.json
T_Rex/0.8.8/nvoc-miner.json
XMR_Stak/2.5.2/nvoc-miner.json
XMR_Stak/2.4.7/nvoc-miner.json
XMR_Stak/2.4.4/nvoc-miner.json
XMR_Stak/2.5.1/nvoc-miner.json
ZENEMYminer/1.28/nvoc-miner.json
Z_EWBF/0.6)

Do your Choice:
LuKePicci commented 5 years ago

Finally managed to reproduce your issue. There was an IFS override I didn't took care about since I considered to be relevant only for the read command while it actually affects for enumerations too but I wasn't setting in my tests. Cleaned up the awful pushd/popd solution I previously implemented, switched back to full paths. Now exploiting IFS for any path enumeration, hopefully improving stability. I also did some more stress-test against paths containing spaces, at least up to the NVOC_MINERS root.

LuKePicci commented 5 years ago

Should we merge this or you still have something to push?

delawr0190 commented 5 years ago

I will test tonight and see what happens.

There are still other miners that weren't working. We'll need to work through those too.

LuKePicci commented 5 years ago

Let me know about 7 and 9, then we move forward to the next batch.

delawr0190 commented 5 years ago

I tried the latest change of PHI2 to CryptoDredge - it works fine. I also added a test for that.

Back on topic - xmrstak now works! I got the following warnings/errors while it was mining, though. I think that it's related to something funky still going on with the config file. It wasn't fatal, but it caused xmrstak to keep trying to reconnect to a placeholder pool name (the none.selected:3333 keeps showing up):

[2019-01-28 20:55:36] : Starting NVIDIA GPU thread 2, no affinity.
CUDA [10.0/9.1] GPU#2, device architecture 61: "GeForce GTX 1050 Ti"... device init succeeded
[2019-01-28 20:55:37] : NVIDIA: use library 'xmrstak_cuda_backend'
[2019-01-28 20:55:37] : MEMORY ALLOC FAILED: mlock failed
[2019-01-28 20:55:37] : MEMORY ALLOC FAILED: mlock failed
[2019-01-28 20:55:37] : MEMORY ALLOC FAILED: mlock failed
[2019-01-28 20:55:37] : Fast-connecting to none.selected:3333 pool ...
[2019-01-28 20:55:37] : Fast-connecting to xmr.2miners.com:2222 pool ...
[2019-01-28 20:55:37] : Pool xmr.2miners.com:2222 connected. Logging in...
[2019-01-28 20:55:37] : Difficulty changed. Now: 120001.
[2019-01-28 20:55:37] : Pool logged in.
[2019-01-28 20:57:44] : SOCKET ERROR - [none.selected:3333] CONNECT error: Connection timed out

I recompiled TPccminer - went great. Is there any way that we can get the binaries to go into the miner folders after a fresh recompile? It doesn't seem trivial to have to manually move them for them to run (I compile and it drops them into the top level miner folder - not in the folder for the version it just recompiled). so I have to recompile, move, and then re-run nvOC.

While I was recompiling ANXccminer, this happened (couldn't get it to compile). A lot of the messages below are just for context - the actual error is towards the bottom (permission denied):

Compiling ANXccminer
 This could take a while ...
Submodule 'ANXccminer/src' (https://github.com/anorganix/ccminer-phi.git) registered for path 'src'
Cloning into 'ANXccminer/src'...
remote: Enumerating objects: 328, done.
remote: Counting objects: 100% (328/328), done.
remote: Compressing objects: 100% (265/265), done.
remote: Total 328 (delta 40), reused 325 (delta 40), pack-reused 0
Receiving objects: 100% (328/328), 29.80 MiB | 12.62 MiB/s, done.
Resolving deltas: 100% (40/40), done.
Checking connectivity... done.
Submodule path 'src': checked out 'cd6fab68823e247bb84dd1fa0448d5f75ec4917d'
HEAD is now at cd6fab6... Merge branch 'master' of https://github.com/anorganix/ccminer-phi.git
~/NVOC/mining/miners/ANXccminer/src ~/NVOC/mining/miners
configure.ac:13: installing './compile'
configure.ac:4: installing './config.guess'
configure.ac:4: installing './config.sub'
configure.ac:6: installing './install-sh'
configure.ac:6: installing './missing'
Makefile.am: installing './depcomp'
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking target system type... x86_64-pc-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... gcc3
checking for gcc option to accept ISO C99... none needed
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
.
.
.
make[1]: Leaving directory '/home/m1/NVOC/mining/miners/ANXccminer/src/compat'
make[1]: Entering directory '/home/m1/NVOC/mining/miners/ANXccminer/src'
test -z "ccminer" || rm -f ccminer
rm -f *.o
rm -f Algo256/*.o
rm -f compat/*.o
rm -f lbry/*.o
rm -f lyra2/*.o
rm -f neoscrypt/*.o
rm -f nist5/*.o
rm -f phi/*.o
rm -f quark/*.o
rm -f qubit/*.o
rm -f skein/*.o
rm -f sph/*.o
rm -f streebog/*.o
rm -f x11/*.o
rm -f x13/*.o
rm -f x14/*.o
rm -f x15/*.o
rm -f x17/*.o
rm -f *.tab.c
test -z "" || rm -f
test . = "." || test -z "" || rm -f
rm -f Algo256/.deps/.dirstamp
rm -f Algo256/.dirstamp
rm -f compat/.deps/.dirstamp
rm -f compat/.dirstamp
rm -f lbry/.deps/.dirstamp
rm -f lbry/.dirstamp
rm -f lyra2/.deps/.dirstamp
rm -f lyra2/.dirstamp
rm -f neoscrypt/.deps/.dirstamp
rm -f neoscrypt/.dirstamp
rm -f nist5/.deps/.dirstamp
rm -f nist5/.dirstamp
rm -f phi/.deps/.dirstamp
rm -f phi/.dirstamp
rm -f quark/.deps/.dirstamp
rm -f quark/.dirstamp
rm -f qubit/.deps/.dirstamp
rm -f qubit/.dirstamp
rm -f skein/.deps/.dirstamp
rm -f skein/.dirstamp
rm -f sph/.deps/.dirstamp
rm -f sph/.dirstamp
rm -f streebog/.deps/.dirstamp
rm -f streebog/.dirstamp
rm -f x11/.deps/.dirstamp
rm -f x11/.dirstamp
rm -f x13/.deps/.dirstamp
rm -f x13/.dirstamp
rm -f x14/.deps/.dirstamp
rm -f x14/.dirstamp
rm -f x15/.deps/.dirstamp
rm -f x17/*.o
rm -f *.tab.c
test -z "" || rm -f
test . = "." || test -z "" || rm -f
rm -f Algo256/.deps/.dirstamp
rm -f Algo256/.dirstamp
rm -f compat/.deps/.dirstamp
rm -f compat/.dirstamp
rm -f lbry/.deps/.dirstamp
rm -f lbry/.dirstamp
rm -f lyra2/.deps/.dirstamp
rm -f lyra2/.dirstamp
rm -f neoscrypt/.deps/.dirstamp
rm -f neoscrypt/.dirstamp
rm -f nist5/.deps/.dirstamp
rm -f nist5/.dirstamp
rm -f phi/.deps/.dirstamp
rm -f phi/.dirstamp
rm -f quark/.deps/.dirstamp
rm -f quark/.dirstamp
rm -f qubit/.deps/.dirstamp
rm -f qubit/.dirstamp
rm -f skein/.deps/.dirstamp
rm -f skein/.dirstamp
rm -f sph/.deps/.dirstamp
rm -f sph/.dirstamp
rm -f streebog/.deps/.dirstamp
rm -f streebog/.dirstamp
rm -f x11/.deps/.dirstamp
rm -f x11/.dirstamp
rm -f x13/.deps/.dirstamp
rm -f x13/.dirstamp
rm -f x14/.deps/.dirstamp
rm -f x14/.dirstamp
rm -f x15/.deps/.dirstamp
rm -f x15/.dirstamp
rm -f x17/.deps/.dirstamp
rm -f x17/.dirstamp
rm -f cpuminer-config.h stamp-h1
rm -f TAGS ID GTAGS GRTAGS GSYMS GPATH tags
rm -f cscope.out cscope.in.out cscope.po.out cscope.files
make[1]: Leaving directory '/home/m1/NVOC/mining/miners/ANXccminer/src'
rm -f config.status config.cache config.log configure.lineno config.status.lineno
rm -rf ./.deps compat/.deps lyra2/.deps neoscrypt/.deps sph/.deps x13/.deps
rm -f Makefile
/home/m1/NVOC/mining/miners/ANXccminer/src/build.sh: line 11: ./autogen.sh: Permission denied
done
/home/m1/NVOC/mining/miners/ANXccminer/src/build.sh: line 14: ./configure.sh: Permission denied
make: *** No targets specified and no makefile found.  Stop.
cp: cannot stat '/home/m1/NVOC/mining/miners/ANXccminer/src/ccminer': No such file or directory
~/NVOC/mining/miners

Finished compiling ANXccminer

I recompiled ktccminer and I'm still getting the same error I got before regarding free() invalid pointer. I actually found this github issue where @papampi was communicating with KlausT regarding it. It seems like this is a rare error, which makes me feel like something is going on with nvOC maybe? Not entirely sure - maybe worth an upgrade to ccminer-klaust 8.23? https://github.com/KlausT/ccminer/issues/257

I tried to compile ktccminer_cryptonight and I got this (failed to compile):

Do your Choice: KTccminer_cryptonight/3.05
KTccminer_cryptonight/3.05
Initializing sources submodule
error: pathspec '/home/m1/NVOC/mining/miners/KTccminer_cryptonight/3.05/nvoc-miner.json/' did not match any file(s) known to git.
Relative path can only be used from the toplevel of the working tree
Submodule 'KTccminer_cryptonight/src' (https://github.com/KlausT/ccminer-cryptonight) registered for path '../src'
Cloning into 'KTccminer_cryptonight/src'...
remote: Enumerating objects: 129, done.
remote: Counting objects: 100% (129/129), done.
remote: Compressing objects: 100% (123/123), done.
remote: Total 129 (delta 3), reused 69 (delta 0), pack-reused 0
Receiving objects: 100% (129/129), 11.91 MiB | 9.83 MiB/s, done.
Resolving deltas: 100% (3/3), done.
Checking connectivity... done.
fatal: reference is not a tree: bedaf007d4619fc4157aeafb59b44850f08d93f1
Unable to checkout 'bedaf007d4619fc4157aeafb59b44850f08d93f1' in submodule path '../src'
./nvOC_miner_update.sh: line 106: git -C /home/m1/NVOC/mining/miners/KTccminer_cryptonight/3.05/../src checkout --force 7061f3c78e52a03f7ff5d0743900312de5bb24fc: No such file or directory
Checkout from shallow clone failed, fetching old commits...
remote: Enumerating objects: 1908, done.
remote: Counting objects: 100% (1908/1908), done.
remote: Compressing objects: 100% (760/760), done.
remote: Total 1839 (delta 1127), reused 1780 (delta 1069), pack-reused 0
Receiving objects: 100% (1839/1839), 7.42 MiB | 6.48 MiB/s, done.
Resolving deltas: 100% (1127/1127), completed with 53 local objects.
remote: Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
From https://github.com/KlausT/ccminer-cryptonight
 * [new tag]         1.01       -> 1.01
 * [new tag]         1.02       -> 1.02
 * [new tag]         1.03       -> 1.03
 * [new tag]         2.01       -> 2.01
 * [new tag]         2.02       -> 2.02
 * [new tag]         2.03       -> 2.03
 * [new tag]         2.04       -> 2.04
 * [new tag]         2.05       -> 2.05
 * [new tag]         2.06       -> 2.06
 * [new tag]         2.06beta   -> 2.06beta
 * [new tag]         3.00       -> 3.00
 * [new tag]         3.01       -> 3.01
 * [new tag]         3.02       -> 3.02
 * [new tag]         3.03       -> 3.03
 * [new tag]         3.04       -> 3.04
 * [new tag]         3.05       -> 3.05
 * [new tag]         v0.1-alpha -> v0.1-alpha
 * [new tag]         v0.11      -> v0.11
 * [new tag]         v0.12      -> v0.12
 * [new tag]         v0.13      -> v0.13
 * [new tag]         v0.14      -> v0.14
 * [new tag]         v0.15      -> v0.15
 * [new tag]         v0.15-rc1  -> v0.15-rc1
 * [new tag]         v0.16      -> v0.16
 * [new tag]         v0.17      -> v0.17
./nvOC_miner_update.sh: line 110: git -C /home/m1/NVOC/mining/miners/KTccminer_cryptonight/3.05/../src checkout --force 7061f3c78e52a03f7ff5d0743900312de5bb24fc: No such file or directory
Checkout from default branch failed, fetching other branches...
remote: Enumerating objects: 44, done.
remote: Counting objects: 100% (44/44), done.
remote: Total 66 (delta 44), reused 44 (delta 44), pack-reused 22
Unpacking objects: 100% (66/66), done.
From https://github.com/KlausT/ccminer-cryptonight
 * [new branch]      cuda10     -> origin/cuda10
 * [new branch]      cuda9      -> origin/cuda9
 * [new branch]      esfomeado  -> origin/esfomeado
 * [new branch]      memdebug   -> origin/memdebug
 * [new branch]      vc2017     -> origin/vc2017
 * [new branch]      vs2015     -> origin/vs2015
./nvOC_miner_update.sh: line 115: git -C /home/m1/NVOC/mining/miners/KTccminer_cryptonight/3.05/../src checkout --force 7061f3c78e52a03f7ff5d0743900312de5bb24fc: No such file or directory
Unable to checkout submodule, can't find target commit.
/home/m1/NVOC/mining/miners/KTccminer_cryptonight/3.05/nvoc-miner.json: can't compile Klaust ccminer-cryptonight, no sources available in '../src'

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
LuKePicci commented 5 years ago

TPccminer is still using the legacy compiler script which is not version-aware, I think it's not worth of patching the legacy scripts to get the binary copied in the right place, instead we would spend time into switching it also to a PM (where this happens by design).

Same thing for the newer KTccminer, if anybody builds up a pm package for it we can add it very quickly.

ANXccminer build script is assuming some other scripts as executable while they aren't so from the git repo already. We can workaround this by manually marking them as executable but we should consider issuing a PR for it instead to patch its own build script or execution perm.

KTccminer_cryptonight should checkout fine now. Also the compiler function had some issues with paths.

Please, try to recompile xmr-stak also. Nothing related to the config file, just a matter of testing the recompilation too.

papampi commented 5 years ago

Sorry, was out of town for couple of days. Will try to catch up.

Do we need to have all these legacy/old miners at all? Dont think with all the new miners anyone use them anymore.

papampi commented 5 years ago

Energiminer on ubuntu 16.04 need some updated libraries Will make the change for the next image Energimner getting started page: https://guard-energi.minecrypto.pro/index.php?page=gettingstarted

apt-get --assume-yes install software-properties-common
add-apt-repository ppa:ubuntu-toolchain-r/test
apt-get update
apt-get --assume-yes install gcc-4.9
apt-get upgrade libstdc++6
papampi commented 5 years ago

I say we drop these miners that are not updated for more than a year:

Alexis ccminer (ASccminer): on Feb 11, 2015 anorganix ccminer (ANXccminer): Jan 9, 2018 krnlx/ccminer-xevan (KXccminer):Oct 6, 2017 Nanashi ccminer (NAccminer): Aug 18, 2017 SP_SUPRminer: No binaries and miner added ccminer SPMod (SPccminer): Jan 2, 2017 VERTminer Nov 4, 2017

LuKePicci commented 5 years ago

It's totally up to you, I never used those miners, if nobody is actually using them drop them.

papampi commented 5 years ago

We can add any of them with updated manifest if anyone wanted.

papampi commented 5 years ago

Anyone tested grin-miner?