nvOC update script: typo for stopping watchdog

[Alysko]

Hi, line 4, pkill -f 5watcdog should be pkill -f 5watchdog

[LuKePicci]

Good catch.

[LuKePicci]

I'm pretty confident that stopping miner while installing updates may not be necessary.

[papampi]

@LuKePicci Dont you think when miner is running untar can not overwrite the running miner and gets "file busy error"?

[LuKePicci]

If nobody else or the miner itself opened that binary file it should not. Ethminer for sure doesn't.

[papampi]

Miner is running and is using it so the file should be busy and can not be over written. I'm sure many times when I try to copy new miners, it gave me file busy error, may be tar is different from copy.

[LuKePicci]

Normally, the executable file should not be busy if it is running, unless the process explicitly opened that file. Which miner gives you that error?

[papampi]

Dont remember, Claymore or DSTM

[LuKePicci]

Try to overwrite them when running, if they gives you the error we can kill them before overwriting with the updated version. so the running miner does not get killed if it is not getting updated or does not keep an open handle on the binary executable.

[papampi]

Good idea ...

8

[Alysko]

Be carefull, I already had problem updating miners while mining. Justly sort of "file busy error".

[papampi]

That is taken care of in PR #8 If a miner has update and is running it will stop only for a second to copy new one and start again. No time is wasted...

[Alysko]

Be carefull, I already had problem updating miners while mining. Justly sort of "file busy error".

[papampi]

You mean you tested PR #8 and it gives you error?

[LuKePicci]

Fixed