search

papandreou / express-processimage

Express middleware that processes served images according to the query string
BSD 3-Clause "New" or "Revised" License
56 stars 18 forks source link

Requests were getting hanged with 'secondGuessSourceContentType' for empty images #160

Closed paras20xx closed 3 years ago

papandreou commented 3 years ago

Hey Priyank, long time! 🤗

Nice find, but it's curious that the test times out on CI? That kinda indicates that it's not fixed by this patch? 🤔

paras20xx commented 3 years ago

@papandreou hi :smile: Yes ... I was looking into that ... on my local (with Node JS v14.17.6), the tests were working, realized the issue from CI report.

Also, as per the CI logs, even npm install seems to be failing, which is weird. I'll try to investigate if some sub-dependency is causing that issue.

papandreou commented 3 years ago

Thanks for giving this project a long overdue health check 👨‍⚕️

paras20xx commented 3 years ago

@papandreou The issue with npm install was apparently some weird/intermittent issue. I tested with some reverts and re-reverts and it eventually went away.

The issue for older versions of Node appeared to be going deeper into streams (related to "impro" package). But, I was able to implement a minor workaround in the fix part.

The "Coverage" test is failing in the "upload" step. I'm not sure if it is supposed to work or not. For your reference: https://github.com/papandreou/express-processimage/runs/3662154920

Kindly merge if the changes look alright :-)

papandreou commented 3 years ago

Released in 10.2.1, thanks :+1:

paras20xx commented 3 years ago

Thank you :grin: