Added possibility to set binary path of pngquant manually

papandreou / node-pngquant

The pngquant utility as a readable/writable stream

BSD 3-Clause "New" or "Revised" License

82 stars 23 forks source link

Added possibility to set binary path of pngquant manually #10

Closed fela98 closed 8 years ago

fela98 commented 8 years ago

Added possibility to set binary path of pngquant manually. Pretty useful when using this tool and if you want to hijack the command line with for instance a Docker container. This would also make it possible to use a specific version (or fork) of pngquant on a system where multiple versions are installed.

coveralls commented 8 years ago

Coverage decreased (-2.4%) to 85.0% when pulling 29dba17c29e3ed86394155c544d615205274bfee on fela98:master into e55a918eddbd2a8cec515796f7eb345038a4eed3 on papandreou:master.

papandreou commented 8 years ago

Thanks for the contribution! I'm cool with the feature, but have a quibble with the implementation -- se my comment :)

fela98 commented 8 years ago

Sorry for the mistakes, hope I fixed them now. Is this ok to merge now or are there still things that need a fix?

papandreou commented 8 years ago

:+1:, merging.

papandreou commented 8 years ago

Released as 1.1.0, thanks!

coveralls commented 8 years ago

Coverage decreased (-3.2%) to 84.158% when pulling 472bb84b833377f080495a1700de42355053e62a on fela98:master into e55a918eddbd2a8cec515796f7eb345038a4eed3 on papandreou:master.