papandreou / node-pngquant

The pngquant utility as a readable/writable stream
BSD 3-Clause "New" or "Revised" License
82 stars 23 forks source link

Upgrade eslint-config-prettier to version 6.0.0 #33

Closed depfu[bot] closed 5 years ago

depfu[bot] commented 5 years ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ eslint-config-prettier (^5.0.0 → ^6.0.0) · Repo · Changelog

Release Notes

6.0.0 (from changelog)

  • Changed: The CLI helper tool now considers no-confusing-arrow to conflict if you use the default value of its allowParens option. The default was changed to true in ESLint 6, which conflicts with Prettier.

    If the CLI helper tool gives you errors about this after upgrading, the solution is to change this:

    {
      "rules": {
        "no-confusing-arrow": ["error"]
      }
    }

    Into this:

    {
      "rules": {
        "no-confusing-arrow": ["error", { "allowParens": false }]
      }
    }

    The latter works in both ESLint 6 as well as in ESLint 5 and older.

  • Improved: eslint --print-config usage instructions. The CLI tool help text as well as the documentation has been updated to suggest commands that work in ESLint 6.0 as well as in ESLint 5 and older. (Instead of eslint --print-config ., use eslint --print-config path/to/main.js.)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 7 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 80.769% when pulling c6241924f002ecbc45534a93e0046e6817e67b86 on depfu/update/npm/eslint-config-prettier-6.0.0 into b429047a94d64411b036e1bf127097bec228ae40 on master.