Closed MJafarMashhadi closed 4 years ago
@MJafarMashhadi This is looking good and a very useful addition. For the ocaml implementation, we also have an 'answerer' that you can set as the "other side" of the send_request function (https://github.com/paparazzi/pprzlink/blob/master/lib/v2.0/ocaml/pprzLink.ml#L789). Do you think you could add that as well ? If you don't have the time, this might be done later as well.
Thanks! Yeah I could do that, it's not that difficult. Should I add it here or open another PR?
It's fine to do it in this PR, thanks again
Sure, I'll let you know when I'm done
@gautierhattenberger I'm done, please check when you could.
@gautierhattenberger Hi again, I found a small bug in send_request
. I didn't test it after adding the request answerer method which changed a parameter in the callback. Can it be merged again? I'll have to open another pull request otherwise.
I wish we had more tests!
Opened a new PR
IvyMessagesInterface
now has asend_request
method that implements advanced request mechanism.Example: