search

paparazzi / pprzlink

Message and communication library for the Paparazzi UAV system
Other
25 stars 55 forks source link

added compressed remote GPS message for limited datalinks #14

Closed kirkscheper closed 8 years ago

kirkscheper commented 8 years ago

Re-purposed the WC_RSSI message (which appeared not be be used). updated remote_gps to be fowarded. added a very small gps message and a swarming message.

flixr commented 8 years ago

validation failed, please fix wrong field close tags

kirkscheper commented 8 years ago

I get a bunch of unaligned message errors when I make the messages in a test (in messages that are already in the code). Shall I move the message items around to correct that or is it not an issue?

flixr commented 8 years ago

what test and what messages?

kirkscheper commented 8 years ago

never mind, ends up that the intermcu is not possible to be aligned

flixr commented 8 years ago

There is also too much stuff in one commit/PR that makes it really hard to merge only some of your other pull requests... see remote_gps_small branch, do you really want the ac_id removed?

kirkscheper commented 8 years ago

I don't want the ac_id removed, I just moved it to the end of the message to stop the not aligned error when that is important.

The branch looks good, pull it!.

flixr commented 8 years ago

For the RSSI message, should it get some field to indicate where the RSSI is from?

kirkscheper commented 8 years ago

Yea, I guess you could do that, I use it now to communicate the rssi received at the Bluetooth dongle to the drone so the acid is in the message sender ac_id. But yea, of course if you use the message as a downlink then the explicit ID is interesting, haha. I will add it.

Kirk On 25 Apr 2016 11:23 p.m., "Felix Ruess" notifications@github.com wrote:

For the RSSI message, should it get some field to indicate where the RSSI is from?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/paparazzi/pprzlink/pull/14#issuecomment-214443591

flixr commented 8 years ago

I was more thinking about different components on the aircraft reporting RSSI, but if we don't need that right now, maybe we better wait until we add a component id to all messages?

flixr commented 8 years ago

Added the RSSI message with ab69fa785b6145037c949873d92a9aed65160949

kirkscheper commented 8 years ago

I removed the swarm message for now, in the end I am not sure this will be useful for others. The compressed message may be useful though...

flixr commented 8 years ago

LGTM @gautierhattenberger fine to merge it?