search

paparazzi / pprzlink

Message and communication library for the Paparazzi UAV system
Other
24 stars 55 forks source link

heading setpoint in float #49

Closed EwoudSmeur closed 7 years ago

EwoudSmeur commented 7 years ago

related to https://github.com/paparazzi/paparazzi/pull/2051

gautierhattenberger commented 7 years ago

It is not necessary any more to specify alt unit coef for known units: unit="rad" alt_unit="deg"

flixr commented 7 years ago

IMHO there is no real benefit in changing the ROTORCRAFT_FP carrot_psi field to float, it will only make things not work properly anymore if the airborne and ground version are not the same... For the HOVER_LOOP message I don't really care that much as it is basically only for debugging...

podhrmic commented 7 years ago

merging so it works with paparazzi

flixr commented 7 years ago 

Sorry, my bad... didn't see that the commit was already changed to only update the HOVER_LOOP message
podhrmic commented 7 years ago

@flixr I merged it because https://github.com/paparazzi/paparazzi/commit/86baffe98a0181afe1d1348c1c44b143cbee4444 changed HOVER_LOOP message, so without this commit it printed warning:

firmwares/rotorcraft/guidance/guidance_h.c: In function 'send_hover_loop':
firmwares/rotorcraft/guidance/guidance_h.c:136:28: warning: passing argument 20 of 'pprz_msg_send_HOVER_LOOP' from incompatible pointer type [-Wincompatible-pointer-types]
                            &guidance_h.sp.heading);
                            ^

I didn't check it too closely since you already approved it so I thought this is a part of the commit as mentioned.