papataco14 / pe

0 stars 0 forks source link

Case sensitive command words #3

Open papataco14 opened 1 year ago

papataco14 commented 1 year ago

image.png

Currently, it seems that for the list-dentist command (and possibly all the other commands), typing it in uppercase causes an invalid command format error. Not allowing this seems to not add much value, while allowing it does.

nus-se-bot commented 1 year ago

Team's Response

This would constitute more of a feature enhancement, rather than a bug.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The bug is indeed a feature flaw.

Disallowing a correct command purely because of wrong casing is sure to cause an inconvenience to some users, as they now have to retype the entire command again. It is not uncommon to use caps lock when using computers.

Furthermore, the team did not provide any justifications as to why they block such an input in the first place, as allowing for case-insensitivity in the command word could have been implemented with a simple toLowerCase in the the parsing of the user input for command words. According to the website, incorrect case sensitivity and unnecessary input blocking are considered to be feature flaws.

image.png

image.png

The reason given by the developer team is not justifiable for rejecting this feature flaw outright.